Date: Mon, 27 Jul 2009 15:11:58 -0600
From: Jonathan Corbet <corbet@lwn.net>
To: Laurent Pinchart <laurent.pinchart@skynet.be>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Should I use kmap or kmap_atomic to map user pages that will be
 written in a loop ?
Message-ID: <20090727151158.2c5db4eb@bike.lwn.net>
In-Reply-To: <200907262352.09797.laurent.pinchart@skynet.be>
References: <200907252341.48526.laurent.pinchart@skynet.be>
	<20090726152655.7488abe4@bike.lwn.net>
	<200907262352.09797.laurent.pinchart@skynet.be>
Organization: LWN.net
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1063
Lines: 23

On Sun, 26 Jul 2009 23:52:09 +0200
Laurent Pinchart <laurent.pinchart@skynet.be> wrote:

> I receive data from the USB subsystem in URB buffers, which are small kernel 
> buffers. As I have to strip headers from those buffers, I can't initialize the 
> URBs to copy data directly to the userspace buffers, so there's at least one 
> memcpy operation involved :-S
> 
> I could indeed append the URBs to a list in the callback called from interrupt 
> context, and process them from a threaded interrupt handler. Would it make 
> much difference ?

Moving the actual copying out of interrupt context seems like a good
idea.  And if you can get away from the whole get_user_pages() and
kmap() mess into a straight copy-to-user-space situation, you'll make
your life easier.  So that would be my recommendation, yes.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/