Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755432AbZG0WiR (ORCPT ); Mon, 27 Jul 2009 18:38:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755037AbZG0WiP (ORCPT ); Mon, 27 Jul 2009 18:38:15 -0400 Received: from smtp-out.google.com ([216.239.33.17]:50332 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754516AbZG0WiO (ORCPT ); Mon, 27 Jul 2009 18:38:14 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=LLax8rxN8fBM/2DCB/Tl9CziTVl5T3PBmpOCV4uyDsoc0DzYRJY7V7xG3QICMviip OB/g8JEF9EjZd9Dt1F2og== Date: Mon, 27 Jul 2009 15:38:03 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Christoph Lameter cc: Pekka Enberg , Larry Finger , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Johannes Berg Subject: Re: [Bug #13319] Page allocation failures with b43 and p54usb In-Reply-To: Message-ID: References: <4A6CF220.7080605@lwfinger.net> <84144f020907270008h2a985278of68e70ff1ee9265c@mail.gmail.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 23 On Mon, 27 Jul 2009, Christoph Lameter wrote: > My prosal was to use the size and objsize parameters. You would only have > to call calculate_sizes() twice when the comparison of the order of size > and objsize would be different. > > Doing so would simplify additing future flags. If you do your own > calculations (like in the patch) then you have to replicate the size > calculation from calculate_sizes() somehow. Is the duplicate calculation > really accurate regarding alignment and other special casing? > Ok, fair enough. It seems like a matter of taste in implementation but your proposal is also more extendable than mine, and I'm definitely not going to argue your taste vs. mine when it comes to slub :) I'll write an incremental patch on top of Pekka's for-next branch to implement your idea. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/