Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753343AbZG1HM7 (ORCPT ); Tue, 28 Jul 2009 03:12:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753337AbZG1HM6 (ORCPT ); Tue, 28 Jul 2009 03:12:58 -0400 Received: from brick.kernel.dk ([93.163.65.50]:58605 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665AbZG1HM4 (ORCPT ); Tue, 28 Jul 2009 03:12:56 -0400 Date: Tue, 28 Jul 2009 09:12:56 +0200 From: Jens Axboe To: Nikanth Karthikesan Cc: Hannes Reinecke , linux-kernel@vger.kernel.org, Tejun Heo , device-mapper development Subject: Re: [RESEND][PATCH] Send uevents for disk write_protect changes Message-ID: <20090728071256.GQ4148@kernel.dk> References: <200907211128.07252.knikanth@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200907211128.07252.knikanth@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1962 Lines: 71 On Tue, Jul 21 2009, Nikanth Karthikesan wrote: > Hi > > This patch is needed for the dm-multipath, so that the daemon can capture the > event and reload the dm table when the read-only setting of the disk changes. > Can this be merged? Looks fine to me, merged for 2.6.32. > > Thanks > Nikanth > > From: Hannes Reinecke > Subject: Send uevents for write_protect changes > > Whenever a block device changes it's read-only attribute > notify the userspace about it. > > Signed-off-by: Hannes Reinecke > Signed-off-by: Nikanth Karthikesan > > --- > > diff --git a/block/genhd.c b/block/genhd.c > index f4c64c2..b89328e 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -1215,6 +1215,16 @@ void put_disk(struct gendisk *disk) > > EXPORT_SYMBOL(put_disk); > > +static void set_disk_ro_uevent(struct gendisk *gd, int ro) > +{ > + char event[] = "DISK_RO=1"; > + char *envp[] = { event, NULL }; > + > + if (!ro) > + event[8] = '0'; > + kobject_uevent_env(&disk_to_dev(gd)->kobj, KOBJ_CHANGE, envp); > +} > + > void set_device_ro(struct block_device *bdev, int flag) > { > bdev->bd_part->policy = flag; > @@ -1227,8 +1237,12 @@ void set_disk_ro(struct gendisk *disk, int flag) > struct disk_part_iter piter; > struct hd_struct *part; > > - disk_part_iter_init(&piter, disk, > - DISK_PITER_INCL_EMPTY | DISK_PITER_INCL_PART0); > + if (disk->part0.policy != flag) { > + set_disk_ro_uevent(disk, flag); > + disk->part0.policy = flag; > + } > + > + disk_part_iter_init(&piter, disk, DISK_PITER_INCL_EMPTY); > while ((part = disk_part_iter_next(&piter))) > part->policy = flag; > disk_part_iter_exit(&piter); > > -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/