Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752956AbZG1OpV (ORCPT ); Tue, 28 Jul 2009 10:45:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752638AbZG1OpV (ORCPT ); Tue, 28 Jul 2009 10:45:21 -0400 Received: from vervifontaine.sonytel.be ([80.88.33.193]:41234 "EHLO pophost.sonytel.be" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750865AbZG1OpT (ORCPT ); Tue, 28 Jul 2009 10:45:19 -0400 Date: Tue, 28 Jul 2009 16:45:16 +0200 (CEST) From: Geert Uytterhoeven To: Phillip Lougher cc: Herbert Xu , linux-crypto@vger.kernel.org, Linux Kernel Development , squashfs-devel@lists.sourceforge.net Subject: Re: [PATCH/RFC] crypto: compress - Return produced bytes in crypto_{, de}compress_{update, final}() (was: Re: [PATCH/RFC] crypto: compress - Add comp_request.total_out In-Reply-To: <49ED090F.4050503@lougher.demon.co.uk> Message-ID: References: <1235569394-15217-3-git-send-email-Geert.Uytterhoeven@sonycom.com> <1235569394-15217-4-git-send-email-Geert.Uytterhoeven@sonycom.com> <1235569394-15217-5-git-send-email-Geert.Uytterhoeven@sonycom.com> <1235569394-15217-6-git-send-email-Geert.Uytterhoeven@sonycom.com> <1235569394-15217-7-git-send-email-Geert.Uytterhoeven@sonycom.com> <20090307104637.GB8731@gondor.apana.org.au> <49B36A18.5030506@lougher.demon.co.uk> <20090420060313.GA891@gondor.apana.org.au> <49ED090F.4050503@lougher.demon.co.uk> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2260 Lines: 63 On Tue, 21 Apr 2009, Phillip Lougher wrote: > Geert Uytterhoeven wrote: > > On Mon, 20 Apr 2009, Herbert Xu wrote: > > > On Tue, Mar 24, 2009 at 05:33:01PM +0100, Geert Uytterhoeven wrote: > > > > Here's an alternative patch, which does exactly that. > > > > Phillip, what do you think? > > > > > > > > Thanks for your comments! > > > > > > > > >From be7d630f96a85d3ce48716b8e328563ba217647b Mon Sep 17 00:00:00 2001 > > > > From: Geert Uytterhoeven > > > > Date: Tue, 24 Mar 2009 17:19:05 +0100 > > > > Subject: [PATCH] crypto: compress - Return produced bytes in > > > > crypto_{,de}compress_{update,final}() > > > > > > > > If crypto_{,de}compress_{update,final}() succeed, return the actual > > > > number of > > > > bytes produced instead of zero, so their users don't have to calculate > > > > that > > > > theirselves. > > > > > > > > Signed-off-by: Geert Uytterhoeven > > > I certainly prefer this version over the other one? Do you want to > > > submit crypto API portion of this? > > > > If you think I should submit it now, I can do it. But I'm still waiting for > > Phillip's comments. > > I think I said they looked OK to me. But, I want to do performance tests > to see if there's any performance degradation over vanilla zlib, and see > if they cope gracefully with corrupted filesystems. > > Herbert, are the other cryto API patches in linux-next (or any other > git repository)? (in the mean time, all of this has been in mainline since a while) Phillip, any news from you? Thanks! With kind regards, Geert Uytterhoeven Software Architect Techsoft Centre Technology and Software Centre Europe The Corporate Village ? Da Vincilaan 7-D1 ? B-1935 Zaventem ? Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 ? RPR Brussels Fortis ? BIC GEBABEBB ? IBAN BE41293037680010 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/