Date: Tue, 28 Jul 2009 13:05:54 -0500
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, oleg@redhat.com, roland@redhat.com,
       "Eric W. Biederman" <ebiederm@xmission.com>,
       Oren Laadan <orenl@cs.columbia.edu>,
       Alexey Dobriyan <adobriyan@gmail.com>,
       Containers <containers@lists.linux-foundation.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Deny CLONE_PARENT|CLONE_NEWPID combination
Message-ID: <20090728180553.GB6427@us.ibm.com>
References: <20090728164406.GA17275@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090728164406.GA17275@us.ibm.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1594
Lines: 42

Quoting Sukadev Bhattiprolu (sukadev@linux.vnet.ibm.com):
> 
> Deny CLONE_PARENT|CLONE_NEWPID combination.
> 
> CLONE_PARENT was used to implement an older threading model.  For consistency
> with the CLONE_THREAD check in copy_pid_ns(), disable CLONE_PARENT and
> CLONE_SIGHAND with CLONE_NEWPID, at least until the required semantics of
> the pid namespaces are clear.
> 
> Changelog[v3]:
> 	Remove CLONE_SIGHAND and for now only fail CLONE_NEWPID|CLONE_PARENT.

(FWIW your patch description does not reflect this...)

> Changelog[v2]:
> 	[Eric Biederman] Disable CLONE_SIGHAND also ?
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
> Acked-by: Roland McGrath <roland@redhat.com>
> Acked-by: Serge Hallyn <serue@us.ibm.com>
> ---
>  kernel/pid_namespace.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-mmotm/kernel/pid_namespace.c
> ===================================================================
> --- linux-mmotm.orig/kernel/pid_namespace.c	2009-07-16 10:03:01.000000000 -0700
> +++ linux-mmotm/kernel/pid_namespace.c	2009-07-16 11:37:24.000000000 -0700
> @@ -118,7 +118,7 @@
>  {
>  	if (!(flags & CLONE_NEWPID))
>  		return get_pid_ns(old_ns);
> -	if (flags & CLONE_THREAD)
> +	if (flags & (CLONE_THREAD|CLONE_PARENT))
>  		return ERR_PTR(-EINVAL);
>  	return create_pid_namespace(old_ns);
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/