Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753225AbZG2H23 (ORCPT ); Wed, 29 Jul 2009 03:28:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751199AbZG2H22 (ORCPT ); Wed, 29 Jul 2009 03:28:28 -0400 Received: from smtprelay09.ispgateway.de ([80.67.31.43]:34161 "EHLO smtprelay09.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbZG2H22 (ORCPT ); Wed, 29 Jul 2009 03:28:28 -0400 References: <1247672919-13089-1-git-send-email-petkovbb@gmail.com> <20090723082904.GE3997@dtor-d630.eng.vmware.com> <9ea470500907230221m1664be8ft2aaf63d2550de6f8@mail.gmail.com> <9ea470500907230553h3ae169c0nc6abaeedb08bef1e@mail.gmail.com> <20090727162940.DA90C526EC9@mailhub.coreip.homeip.net> <20090727183733.GB3044@liondog.tnic> <9ea470500907280208v1d8140b5v9d7d7f09df8f060f@mail.gmail.com> <9ea470500907280659m5a65ac2et67651247bf6925c7@mail.gmail.com> Message-ID: X-Mailer: http://www.courier-mta.org/cone/ From: Peter Feuerer To: Borislav Petkov Cc: Dmitry Torokhov , lenb@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] acerhdf: convert to dev_pm_ops Date: Wed, 29 Jul 2009 09:25:51 +0200 Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Df-Sender: 404094 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 35 Hi Boris, Borislav Petkov writes: > On Tue, Jul 28, 2009 at 3:25 PM, Peter Feuerer wrote: > > [..] > >>> That's not a reason for keeping code in the kernel and raising bloat >>> levels unnecessarily. If the driver doesn't need to do anything on >>> resume, then no function is needed. >> >> I don't think the verbose message is useless. If an user has a problem >> with suspend / hibernate I can just ask him to load the module with >> verbose=1 and dmesg tells whether the module is waking up or not. > > Since the driver doesn't do anything upon resume, it _is_ _going_ to > resume just fine. If not, then the problem is located somewhere else, > i.e. you can safely assume that you are resuming ok. Also, it's not like > this is the only verbose printk you have in the driver to not be able to > follow what's going on... Ok, I think you are right. So we will remove the resume functionality and keep just the suspend + freeze calls? Btw, should I resend the 0.5.13 → 0.5.16 patch splitted up, so that Len can apply them? kind regards, --peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/