Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753070AbZG2OY4 (ORCPT ); Wed, 29 Jul 2009 10:24:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752875AbZG2OYz (ORCPT ); Wed, 29 Jul 2009 10:24:55 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:60851 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752819AbZG2OYz (ORCPT ); Wed, 29 Jul 2009 10:24:55 -0400 Date: Wed, 29 Jul 2009 10:24:55 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Greg KH cc: linux-kernel@vger.kernel.org, , , , , Subject: Re: [patch 14/71] USB: EHCI: use the new clear_tt_buffer interface In-Reply-To: <20090729140308.GA15088@suse.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1757 Lines: 46 On Wed, 29 Jul 2009, Greg KH wrote: > On Wed, Jul 29, 2009 at 09:56:31AM -0400, Alan Stern wrote: > > On Tue, 28 Jul 2009, Greg KH wrote: > > > > > 2.6.30-stable review patch. If anyone has any objections, please let us know. > > > > > > ------------------ > > > > > > From: Alan Stern > > > > > > commit 914b701280a76f96890ad63eb0fa99bf204b961c upstream. > > > > > > This patch (as1256) changes ehci-hcd and all the other drivers in the > > > EHCI family to make use of the new clear_tt_buffer callbacks. When a > > > Clear-TT-Buffer request is in progress for a QH, the QH is not allowed > > > to be linked into the async schedule until the request is finished. > > > At that time, if there are any URBs queued for the QH, it is linked > > > into the async schedule. > > > > Greg, can we hold off on applying this patch to the stable tree? > > > > It turns out that this change causes a WARN_ON to trigger in some > > circumstances, and the proposed patch to fix _that_ hasn't yet been > > submitted to the mainline because a few people have reported that it > > leaks DMA pool memory. So far there hasn't been much progress in > > tracking this down. > > Sure, I'll drop it. Should I also drop the patch before this one as > well, which was there only because this patch needed it? In terms of functionality, it doesn't matter. I guess you might as well. > Let me know when/if you ever want it added to the -stable trees in the > future. I will. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/