Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753352AbZG2PYq (ORCPT ); Wed, 29 Jul 2009 11:24:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752026AbZG2PYq (ORCPT ); Wed, 29 Jul 2009 11:24:46 -0400 Received: from qw-out-2122.google.com ([74.125.92.25]:57707 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbZG2PYp convert rfc822-to-8bit (ORCPT ); Wed, 29 Jul 2009 11:24:45 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Wu8LqOyIlWdkZdbdm30WgUsDZUZRKPSkHr8lXibU5RsRr8XGW0iLN2fBmKlxIfifAZ x+kXfTv8eyycjdbv2bURNhelv06JlFJn4GdtJBlaId6UdUASW5Lu+1/SmKmVaL1wQ4Sq eb1C2eJuiCb/9Be9Wk4BfFuqGX56D5Ihw9PPk= MIME-Version: 1.0 In-Reply-To: <74d0deb30907290820x13214f68u82dea4ad229ebdac@mail.gmail.com> References: <74d0deb30907290820x13214f68u82dea4ad229ebdac@mail.gmail.com> Date: Thu, 30 Jul 2009 00:24:44 +0900 Message-ID: Subject: Re: [PATCH] tmio_mmc: Optionally support using platform clock From: Magnus Damm To: pHilipp Zabel Cc: Guennadi Liakhovetski , Ian Molton , linux-kernel@vger.kernel.org, Magnus Damm , akpm@linux-foundation.org, Matt Fleming , Philip Langdale Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1811 Lines: 47 On Thu, Jul 30, 2009 at 12:20 AM, pHilipp Zabel wrote: > On Tue, Jul 28, 2009 at 9:51 AM, Guennadi > Liakhovetski wrote: >> If the platform device has a clock associated with the tmio-mmc device, >> use it. >> >> Signed-off-by: Guennadi Liakhovetski >> Cc: Magnus Damm >> --- >> >> Depends (at least logically) on >> http://marc.info/?l=linux-kernel&m=124782904228865&w=2 >> >> Sorry if I forgot anyone who volunteered to help out with MMC patches. >> >> ?drivers/mmc/host/tmio_mmc.c | ? 21 +++++++++++++++++++++ >> ?drivers/mmc/host/tmio_mmc.h | ? ?3 +++ >> ?include/linux/mfd/tmio.h ? ?| ? ?1 + >> ?3 files changed, 25 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c >> index c246191..2a01572 100644 >> --- a/drivers/mmc/host/tmio_mmc.c >> +++ b/drivers/mmc/host/tmio_mmc.c >> @@ -567,6 +576,11 @@ static int __devinit tmio_mmc_probe(struct platform_device *dev) >> ? ? ? ? ? ? ? ? ? ? ? ?goto unmap_cnf; >> ? ? ? ?} >> >> + ? ? ? host->clk = clk_get(&dev->dev, pdata->clk_name); > > Instead of pdata->clk_name, this should be either NULL or better > "HCLK" (to differentiate from CLK32, not sure if we want to be able to > toggle that, too, in the future). > Passing the clock consumer ID via pdata is just wrong and shouldn't be > needed with clkdev. Really? I think that depends on the clock framework implementation. Remember that this needs to work on other architectures than just ARM. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/