Date: Wed, 29 Jul 2009 18:27:54 +0200
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Will Newton <will.newton@gmail.com>
Cc: dwalker@fifo99.com, linux-kernel@vger.kernel.org,
       Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
       john stultz <johnstul@us.ibm.com>
Subject: Re: [RFC][patch 02/12] remove clocksource inline functions
Message-ID: <20090729182754.2361631b@skybase>
In-Reply-To: <87a5b0800907290836n6bb6da36tb0124e6d4f0673ea@mail.gmail.com>
References: <200907291457.n6TEvDAt003701@d06av06.portsmouth.uk.ibm.com>
	<20090729173231.012d0b89@skybase>
	<87a5b0800907290836n6bb6da36tb0124e6d4f0673ea@mail.gmail.com>
Organization: IBM Corporation
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1242
Lines: 33

On Wed, 29 Jul 2009 16:36:46 +0100
Will Newton <will.newton@gmail.com> wrote:

> On Wed, Jul 29, 2009 at 4:32 PM, Martin
> Schwidefsky<schwidefsky@de.ibm.com> wrote:
> 
> > Hmm, you have an object of type struct clocksource and you do
> > cs->read(cs). If that is not clear enough then I don't know what is. We
> > do that all over the place in the linux kernel. And I personally find
> > these useless wrappers rather annoying. I don't like to have to jump to
> > another place to find out that it just calls the read function of the
> > object.
> 
> An argument for the helper is that it eases grepability. Sure you can
> search for "->read" but that's going to turn up all kinds of
> non-clocksource code as well. grep clocksource_read will get you
> exactly what you want.

That would make sense if the clocksource_read calls are littered all
over the kernel source. But they are not, the only user is
timekeeping.c

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/