Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752516AbZG3C7R (ORCPT ); Wed, 29 Jul 2009 22:59:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752256AbZG3C7Q (ORCPT ); Wed, 29 Jul 2009 22:59:16 -0400 Received: from smtp-out.google.com ([216.239.45.13]:32790 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125AbZG3C7O (ORCPT ); Wed, 29 Jul 2009 22:59:14 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:content-transfer-encoding:x-system-of-record; b=qInPbBn8PZTEal24kSr5+oRcyph8q9/VY3fIrghVsEd0OYBHt73IlJRwBH/k1Ds23 D2vo2jdw+hTREVMz9plGg== MIME-Version: 1.0 In-Reply-To: <20090730015754.GC7326@localhost> References: <1786ab030907281211x6e432ba6ha6afe9de73f24e0c@mail.gmail.com> <33307c790907281449k5e8d4f6cib2c93848f5ec2661@mail.gmail.com> <33307c790907290015m1e6b5666x9c0014cdaf5ed08@mail.gmail.com> <20090729114322.GA9335@localhost> <33307c790907290711s320607b0i79c939104d4c2d61@mail.gmail.com> <20090730010630.GA7326@localhost> <33307c790907291812j40146a96tc2e9c5e097a33615@mail.gmail.com> <20090730015754.GC7326@localhost> Date: Wed, 29 Jul 2009 19:59:09 -0700 Message-ID: <33307c790907291959r47b1bd3ap7cfa06fd5154aaad@mail.gmail.com> Subject: Re: Bug in kernel 2.6.31, Slow wb_kupdate writeout From: Martin Bligh To: Wu Fengguang Cc: Chad Talbott , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Michael Rubin , Andrew Morton , "sandeen@redhat.com" , Michael Davidson Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 24 On Wed, Jul 29, 2009 at 6:57 PM, Wu Fengguang wrote: > On Thu, Jul 30, 2009 at 09:12:26AM +0800, Martin Bligh wrote: >> > I agree on the unification of kupdate and sync paths. In fact I had a >> > patch for doing this. And I'd recommend to do it in two patches: >> > one to fix the congestion case, another to do the code unification. >> > >> > The sync path don't care whether requeue_io() or redirty_tail() is >> > used, because they disregard the time stamps totally - only order of >> > inodes matters (ie. starvation), which is same for requeue_io()/redirty_tail(). >> >> But, as I understand it, both paths share the same lists, so we still have >> to be consistent? > > Then let's first unify the code, then fix the congestion case? :) OK, I will send it out as separate patches. I am just finishing up the testing first. M. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/