Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752708AbZG3K4b (ORCPT ); Thu, 30 Jul 2009 06:56:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751642AbZG3K4a (ORCPT ); Thu, 30 Jul 2009 06:56:30 -0400 Received: from mail.gmx.net ([213.165.64.20]:49248 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751541AbZG3K4a (ORCPT ); Thu, 30 Jul 2009 06:56:30 -0400 X-Authenticated: #20450766 X-Provags-ID: V01U2FsdGVkX18CMXN5NugC2ZGa78lARVmdpmyHgHekmyf/Mfvw9a VT0yGnpaDeSaGW Date: Thu, 30 Jul 2009 12:56:31 +0200 (CEST) From: Guennadi Liakhovetski To: Ian Molton cc: pHilipp Zabel , Paul Mundt , Magnus Damm , Mark Brown , linux-kernel@vger.kernel.org, Pierre Ossman , Magnus Damm Subject: Re: MMC: Make the configuration memory resource optional In-Reply-To: <4A716F1C.2050805@mnementh.co.uk> Message-ID: References: <20090729115817.GA12223@rakim.wolfsonmicro.main> <20090729124233.GA12802@rakim.wolfsonmicro.main> <4A704777.70001@mnementh.co.uk> <4A7053E8.8050303@mnementh.co.uk> <20090729201702.GA28202@linux-sh.org> <74d0deb30907291355n39df7db0v1d7afc93917adc14@mail.gmail.com> <4A716F1C.2050805@mnementh.co.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Y-GMX-Trusted: 0 X-FuHaFi: 0.64 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1284 Lines: 36 On Thu, 30 Jul 2009, Ian Molton wrote: > Ok I've spent some time thinking on this. > > There is _no_ clean solution at present and Im not happy with having more than > one clocking system co-existing in the mmc driver. > > I will produce a patch to completely remove all clocking and power control > from the driver and make it use callbacks in order to achieve this. This will > leave us with a clean driver that will be simple to adapt to the clock API. > > I wont have time to work on it until next week, however, so if anyone wants to > take a stab at it in the meantime, feel free to do so, and I'll review it next > week. While you're at it, please, consider swapping the two lines in tmio_mmc_probe(): - tmio_mmc_clk_stop(host); reset(host); + tmio_mmc_clk_stop(host); Otherwise, I think, reset causes problems trying to access the controller with disabled clock. At least this is needed on SuperH. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/