Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751300AbZG3NsM (ORCPT ); Thu, 30 Jul 2009 09:48:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751133AbZG3NsL (ORCPT ); Thu, 30 Jul 2009 09:48:11 -0400 Received: from www.tglx.de ([62.245.132.106]:46279 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbZG3NsL (ORCPT ); Thu, 30 Jul 2009 09:48:11 -0400 Message-ID: <4A71A483.30507@linutronix.de> Date: Thu, 30 Jul 2009 15:47:47 +0200 From: Sebastian Andrzej Siewior User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707) MIME-Version: 1.0 To: vimal singh CC: Stoyan Gaydarov , linux-kernel@vger.kernel.org, David.Woodhouse@intel.com, sr@denx.de, kay.sievers@vrfy.org, gregkh@suse.de, linux-mtd@lists.infradead.org Subject: Re: [PATCH] [mtd] fixed faulty check References: <1248958178-22599-1-git-send-email-sgayda2@uiuc.edu> <4A719A27.8050509@linutronix.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 527 Lines: 15 vimal singh wrote: > What if you go to 'err_out' due to some other error?? Do not you need > to free 'info'? We have to and of_flash_remove() takes care of it. The initial patch would be shorter if dev_set_drvdata(&dev->dev, info); would be moved prior the kzalloc() Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/