Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752169AbZG3TVU (ORCPT ); Thu, 30 Jul 2009 15:21:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751946AbZG3TVU (ORCPT ); Thu, 30 Jul 2009 15:21:20 -0400 Received: from mail.mnementh.co.uk ([173.45.232.4]:40448 "EHLO mnementh.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbZG3TVT (ORCPT ); Thu, 30 Jul 2009 15:21:19 -0400 Message-ID: <4A71F2A5.4060206@mnementh.co.uk> Date: Thu, 30 Jul 2009 20:21:09 +0100 From: Ian Molton User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Guennadi Liakhovetski CC: pHilipp Zabel , Paul Mundt , Magnus Damm , Mark Brown , linux-kernel@vger.kernel.org, Pierre Ossman , Magnus Damm Subject: Re: MMC: Make the configuration memory resource optional References: <20090729115817.GA12223@rakim.wolfsonmicro.main> <20090729124233.GA12802@rakim.wolfsonmicro.main> <4A704777.70001@mnementh.co.uk> <4A7053E8.8050303@mnementh.co.uk> <20090729201702.GA28202@linux-sh.org> <74d0deb30907291355n39df7db0v1d7afc93917adc14@mail.gmail.com> <4A716F1C.2050805@mnementh.co.uk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 947 Lines: 27 Guennadi Liakhovetski wrote: > While you're at it, please, consider swapping the two lines in > tmio_mmc_probe(): > > - tmio_mmc_clk_stop(host); > reset(host); > + tmio_mmc_clk_stop(host); > > Otherwise, I think, reset causes problems trying to access the controller > with disabled clock. At least this is needed on SuperH. Interesting. I'll see what the result of this is on TMIO - This sequence was garnered from the WinCE driver for the chip. I cant see _why_ this should be a problem, as this disables the card clock, not HCLK. Could you debug further in tmio_mmc_clk_stop() please and see if reordering only one of the two IO accesses cures this? Let me know what you find out. -Ian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/