Return-Path: <linux-kernel-owner+w=401wt.eu-S1752938AbZG3V3A@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752938AbZG3V3A (ORCPT <rfc822;w@1wt.eu>);
	Thu, 30 Jul 2009 17:29:00 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752774AbZG3V3A
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 30 Jul 2009 17:29:00 -0400
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:50820
	"EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752559AbZG3V27 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 30 Jul 2009 17:28:59 -0400
Date: Thu, 30 Jul 2009 14:29:06 -0700 (PDT)
Message-Id: <20090730.142906.266849967.davem@davemloft.net>
To: joe@perches.com
Cc: heder@google.com, lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
       linux-kernel@vger.kernel.org, jengelh@medozas.de
Subject: Re: [PATCH v2 2/2] IPVS: use pr_err and friends instead of
 IP_VS_ERR and friends
From: David Miller <davem@davemloft.net>
In-Reply-To: <1248814615.18284.22.camel@Joe-Laptop.home>
References: <20090728203414.7654.73236.stgit@jazzy.zrh.corp.google.com>
	<20090728203554.7654.29628.stgit@jazzy.zrh.corp.google.com>
	<1248814615.18284.22.camel@Joe-Laptop.home>
X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1205
Lines: 31

From: Joe Perches <joe@perches.com>
Date: Tue, 28 Jul 2009 13:56:55 -0700

> On Tue, 2009-07-28 at 22:35 +0200, Hannes Eder wrote:
>> Since pr_err and friends is used instead of printk there is not point
>> in keeping IP_VS_ERR and friends.
>> +			pr_err("Schedule: port zero only supported "
>> +			       "in persistent services, "
>> +			       "check your ipvs configuration\n");
> 
> You might consider ignoring the checkpatch 80 char limit here
> and consolidate the message into a single string.

I don't think this is such a big deal.

>> -		IP_VS_ERR("ip_vs_svc_unhash(): request for unhash flagged, "
>> -			  "called from %p\n", __builtin_return_address(0));
>> +		pr_err("ip_vs_svc_unhash(): request for unhash flagged, "
>> +		       "called from %p\n", __builtin_return_address(0));
> 
> Maybe use something like:
> 	"%s(): <foo> called from %pf",
> 	 __func__, __builtin_return_address(0)
> 

However I do agree that this change should be made.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/