Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbZGaGza (ORCPT ); Fri, 31 Jul 2009 02:55:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751952AbZGaGz3 (ORCPT ); Fri, 31 Jul 2009 02:55:29 -0400 Received: from mail.gmx.net ([213.165.64.20]:34854 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751928AbZGaGz2 (ORCPT ); Fri, 31 Jul 2009 02:55:28 -0400 X-Authenticated: #20450766 X-Provags-ID: V01U2FsdGVkX18cU2ssCogc31XyUMu2ducZfHQpMBHpT6Z4bP+YAS iJAjM0Clryu3GI Date: Fri, 31 Jul 2009 08:55:30 +0200 (CEST) From: Guennadi Liakhovetski To: Ian Molton cc: pHilipp Zabel , Paul Mundt , Magnus Damm , Mark Brown , linux-kernel@vger.kernel.org, Pierre Ossman , Magnus Damm Subject: Re: MMC: Make the configuration memory resource optional In-Reply-To: <4A71F2A5.4060206@mnementh.co.uk> Message-ID: References: <20090729115817.GA12223@rakim.wolfsonmicro.main> <20090729124233.GA12802@rakim.wolfsonmicro.main> <4A704777.70001@mnementh.co.uk> <4A7053E8.8050303@mnementh.co.uk> <20090729201702.GA28202@linux-sh.org> <74d0deb30907291355n39df7db0v1d7afc93917adc14@mail.gmail.com> <4A716F1C.2050805@mnementh.co.uk> <4A71F2A5.4060206@mnementh.co.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Y-GMX-Trusted: 0 X-FuHaFi: 0.61 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1292 Lines: 36 On Thu, 30 Jul 2009, Ian Molton wrote: > Guennadi Liakhovetski wrote: > > > While you're at it, please, consider swapping the two lines in > > tmio_mmc_probe(): > > > > - tmio_mmc_clk_stop(host); > > reset(host); > > + tmio_mmc_clk_stop(host); > > > > Otherwise, I think, reset causes problems trying to access the controller > > with disabled clock. At least this is needed on SuperH. > > Interesting. I'll see what the result of this is on TMIO - This sequence was > garnered from the WinCE driver for the chip. > > I cant see _why_ this should be a problem, as this disables the card clock, > not HCLK. Could you debug further in tmio_mmc_clk_stop() please and see if > reordering only one of the two IO accesses cures this? Not sure I understood the "reordering only one of the two IO accesses" correctly, but I swapped the two sd_ctrl_write16() calls in tmio_mmc_clk_stop() and no, it didn't cure the problem. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/