Date: Fri, 31 Jul 2009 09:15:18 +0200
From: Jens Axboe <jens.axboe@oracle.com>
To: Damien Wyart <damien.wyart@free.fr>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
       chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org,
       akpm@linux-foundation.org, jack@suse.cz, yanmin_zhang@linux.intel.com,
       richard@rsk.demon.co.uk, fweisbec@gmail.com, Alan.Brunelle@hp.com
Subject: Re: [PATCH 0/9] Per-bdi writeback flusher threads v13
Message-ID: <20090731071518.GN12579@kernel.dk>
References: <1248989044-21605-1-git-send-email-jens.axboe@oracle.com> <20090731063008.GA2796@brouette>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090731063008.GA2796@brouette>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1258
Lines: 37

On Fri, Jul 31 2009, Damien Wyart wrote:
> Hello,
> 
> > Here's the 13th version of the writeback patches. Changes since v12:
> 
> > - Update to 2.6.31-rc4 ('ish, it's on top of current -git, but wil apply
> >   to -rc4 as well).
> > - Drop the last patch in the series, it was a questionable optimization
> >   that needs to be tested and evaluated separately.
> 
> fs/sync.c has changed some time ago and I think your patch needs this
> (which I had lazyly added by hand in v12 without telling):
> 
> --- a/fs/sync.c	2009-07-31 07:32:08.927926281 +0200
> +++ b/fs/sync.c.new	2009-07-31 07:31:52.499801359 +0200
> @@ -118,7 +118,7 @@ restart:
>   */
>  SYSCALL_DEFINE0(sync)
>  {
> -	wakeup_pdflush(0);
> +	wakeup_flusher_threads(0);
>  	sync_filesystems(0);
>  	sync_filesystems(1);
>  	if (unlikely(laptop_mode))

Argh, I had fixed that long ago, but a branch problem yesterday caused
it to be lost just before posting. How annoying. Thanks for the hint,
I'll update the v13 branch and patch.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/