Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752572AbZGaLQe (ORCPT ); Fri, 31 Jul 2009 07:16:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752489AbZGaLQd (ORCPT ); Fri, 31 Jul 2009 07:16:33 -0400 Received: from mail-bw0-f219.google.com ([209.85.218.219]:48958 "EHLO mail-bw0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885AbZGaLQd (ORCPT ); Fri, 31 Jul 2009 07:16:33 -0400 MIME-Version: 1.0 In-Reply-To: <20090730185044.GH3058@console-pimps.org> References: <1248954848.5396.6.camel@localhost> <20090730124543.GF3058@console-pimps.org> <20090730185044.GH3058@console-pimps.org> From: Ohad Ben-Cohen Date: Fri, 31 Jul 2009 14:16:12 +0300 Message-ID: Subject: Re: [PATCH] sdio: add CD disable support To: Matt Fleming Cc: Andrew Morton , Philip Langdale , ian@mnementh.co.uk, pierre@ossman.eu, linux-kernel@vger.kernel.org, linux-embedded@vger.kernel.org, nico@cam.org, nicolas.ferre@rfo.atmel.com, hskinnemoen@atmel.com, tony@atomide.com, david-b@pacbell.net, manuel.lauss@gmail.com, mirq-l@jasper.es, Adrian Hunter , Madhusudhan Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 18 Hi Matt, On Thu, Jul 30, 2009 at 9:50 PM, Matt Fleming wrote: > As David has already said, both comments need fixing up. It is the host > controller driver that decides whether to disable the DAT[3] pull-up, > not the card. If you make those changes then you can add my Acked-by. I'm posting a follow-up patch with the fixes and your Ack, will appreciate your second review. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/