Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbZGaNui (ORCPT ); Fri, 31 Jul 2009 09:50:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751125AbZGaNuh (ORCPT ); Fri, 31 Jul 2009 09:50:37 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:55265 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750896AbZGaNuh (ORCPT ); Fri, 31 Jul 2009 09:50:37 -0400 Date: Fri, 31 Jul 2009 14:50:36 +0100 From: Mark Brown To: Roger Quadros Cc: pHilipp Zabel , lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: Add GPIO enable control to fixed voltage regulator driver Message-ID: <20090731135036.GA626@rakim.wolfsonmicro.main> References: <1249044918-695-1-git-send-email-quadros.roger@gmail.com> <20090731131005.GE17091@sirena.org.uk> <74d0deb30907310625u128ea22cu6fecca53c4a23d40@mail.gmail.com> <20090731133437.GF17091@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: Matrimony is the root of all evil. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 876 Lines: 18 On Fri, Jul 31, 2009 at 04:43:40PM +0300, Roger Quadros wrote: > On Fri, Jul 31, 2009 at 4:34 PM, Mark > Brown wrote: > > Feh, better print a warning for GPIO 0 for at least a kernel release. > > Fortunately we've got no mainline users of fixed voltage regulators. > I think most architectures start their GPIO numbering from 0. > By 'a release', do you mean next Kernel release will be indexing GPIOs from 1? No; I mean the driver should print a warning when using GPIO 0 as a way of managing the transition. Otherwise any existing users will find the driver suddenly starts using a GPIO. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/