Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752735AbZGaRdL (ORCPT ); Fri, 31 Jul 2009 13:33:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752587AbZGaRdK (ORCPT ); Fri, 31 Jul 2009 13:33:10 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:39324 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752542AbZGaRdK (ORCPT ); Fri, 31 Jul 2009 13:33:10 -0400 Subject: Re: [PATCH] clocksource: save mult_orig in clocksource_disable() From: john stultz To: Magnus Damm Cc: Ingo Molnar , linux-kernel@vger.kernel.org, lethal@linux-sh.org, tglx@linutronix.de, akpm@linux-foundation.org In-Reply-To: References: <20090618152432.10136.9932.sendpatchset@rx1.opensource.se> <1245352632.7508.1.camel@localhost.localdomain> <20090731121811.GA3989@elte.hu> Content-Type: text/plain Date: Fri, 31 Jul 2009 10:33:07 -0700 Message-Id: <1249061587.3392.10.camel@work-vm> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1871 Lines: 50 On Fri, 2009-07-31 at 23:23 +0900, Magnus Damm wrote: > On Fri, Jul 31, 2009 at 9:18 PM, Ingo Molnar wrote: > > > > * Magnus Damm wrote: > > > >> On Fri, Jun 19, 2009 at 4:17 AM, john stultz wrote: > >> > On Fri, 2009-06-19 at 00:24 +0900, Magnus Damm wrote: > >> >> From: Magnus Damm > >> >> > >> >> Save clocksource mult_orig in clocksource_disable(). > >> >> > >> >> To fix the common case where ->enable() does not setup > >> >> mult, make sure mult_orig is saved in mult on disable. > >> >> > >> >> Also add comments to explain why we do this. > >> >> > >> >> Signed-off-by: Magnus Damm > >> > > >> > Acked-by: John Stultz > >> > > >> > Thomas, Andrew, please push this for 2.6.31. > >> > >> This one is slowly making it's way in I suppose? > > > > Btw., what specific issue does this fix? The commit description is > > generic, there's no bugzilla link and no other information either > > that could give me an idea about precisely what incarnation of the > > bug you have hit. > > The comments in the actual code gives more details, but that's > probably not where you want this to be explained. I can resend a > version with more verbose commit message early next week if you'd > like. Please let me know if so. > > I'm not aware of any bugzilla links, maybe John knows? No bugzilla link. I found this while reviewing the patch, however at that point it had already been pulled into -tip and my objections somehow never made it to anyone's eyes before it got pulled into mainline. thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/