Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbZGaVB4 (ORCPT ); Fri, 31 Jul 2009 17:01:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753062AbZGaVBz (ORCPT ); Fri, 31 Jul 2009 17:01:55 -0400 Received: from BISCAYNE-ONE-STATION.MIT.EDU ([18.7.7.80]:54574 "EHLO biscayne-one-station.mit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752971AbZGaVBx (ORCPT ); Fri, 31 Jul 2009 17:01:53 -0400 From: Tim Abbott To: Linux Kernel Mailing List Cc: Sam Ravnborg , Anders Kaseorg , Nelson Elhage , Tim Abbott , Hirokazu Takata Subject: [PATCH 2/3] m32r: Move the spi_stack_top and spu_stack_top into .data section. Date: Fri, 31 Jul 2009 16:58:06 -0400 Message-Id: <1249073887-30086-2-git-send-email-tabbott@ksplice.com> X-Mailer: git-send-email 1.6.3.3 In-Reply-To: <1249073887-30086-1-git-send-email-tabbott@ksplice.com> References: <1249073887-30086-1-git-send-email-tabbott@ksplice.com> X-Spam-Flag: NO X-Spam-Score: 0.00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1852 Lines: 61 Since these get squashed into the .data output section by the m32r linker script, it seems likely that they don't need their own input sections. I'd like an explicit confirmation from Hirokazu Takata that this is correct (in particular, that there isn't some hidden reason why there two structures need to be at the start of the .data output section). This patch is preparation for cleaning up the m32r architecture to use the new macros in vmlinux.lds.h; if these sections are indeed not needed, then we can use the RW_DATA_SECTION macro for m32r and save a bunch of redundant code. Signed-off-by: Tim Abbott Cc: Hirokazu Takata --- arch/m32r/kernel/head.S | 4 ++-- arch/m32r/kernel/vmlinux.lds.S | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/m32r/kernel/head.S b/arch/m32r/kernel/head.S index 0a71944..fc4d769 100644 --- a/arch/m32r/kernel/head.S +++ b/arch/m32r/kernel/head.S @@ -268,13 +268,13 @@ ENTRY(empty_zero_page) /*------------------------------------------------------------------------ * Stack area */ - .section .spi + .section .data ALIGN .global spi_stack_top .zero 1024 spi_stack_top: - .section .spu + .section .data ALIGN .global spu_stack_top .zero 1024 diff --git a/arch/m32r/kernel/vmlinux.lds.S b/arch/m32r/kernel/vmlinux.lds.S index eb3e425..1984b9f 100644 --- a/arch/m32r/kernel/vmlinux.lds.S +++ b/arch/m32r/kernel/vmlinux.lds.S @@ -49,8 +49,6 @@ SECTIONS /* writeable */ .data : { /* Data */ - *(.spu) - *(.spi) DATA_DATA CONSTRUCTORS } -- 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/