Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240AbZGaViK (ORCPT ); Fri, 31 Jul 2009 17:38:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751538AbZGaViJ (ORCPT ); Fri, 31 Jul 2009 17:38:09 -0400 Received: from mail.windriver.com ([147.11.1.11]:38831 "EHLO mail.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753190AbZGaViI (ORCPT ); Fri, 31 Jul 2009 17:38:08 -0400 Message-ID: <4A736380.8030101@windriver.com> Date: Fri, 31 Jul 2009 16:34:56 -0500 From: Jason Wessel User-Agent: Thunderbird 2.0.0.22 (X11/20090608) MIME-Version: 1.0 To: Alan Stern CC: gregkh@suse.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net, Ingo Molnar , Andrew Morton , Yinghai Lu , "Eric W. Biederman" Subject: Re: [PATCH 07/10] ehci-dbgp,ehci: Allow early or late use of the dbgp device References: <4A7355EA.60107@windriver.com> In-Reply-To: <4A7355EA.60107@windriver.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 31 Jul 2009 21:34:58.0442 (UTC) FILETIME=[C0B1DEA0:01CA1226] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1736 Lines: 56 Alan Stern wrote: > What happens across a system suspend? > > I assume you mean as a test case: echo -n mem > /sys/power/state The dbgp device goes away entirely, when used with earlyprintk=dbgp,keep. But there is a way to fix it reasonably easily. Perhaps you might ack this resume patch, if you agree? Jason. --- From: Jason Wessel Subject: [PATCH] ehci-dbgp,ehci: Allow dbpg to work with suspend/resume In order for the dbgp driver to survive suspend/resume, on every ehci resume operation the debug controller must get re-initialized. Signed-off-by: Jason Wessel Cc: Greg KH Cc: Alan Stern Cc: dbrownell@users.sourceforge.net Cc: Ingo Molnar Cc: Andrew Morton Cc: Yinghai Lu Cc: "Eric W. Biederman" --- drivers/usb/host/ehci-hub.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/usb/host/ehci-hub.c +++ b/drivers/usb/host/ehci-hub.c @@ -204,6 +204,13 @@ static int ehci_bus_resume (struct usb_h return -ESHUTDOWN; } + if (unlikely(ehci->debug)) { + if (ehci->debug && !dbgp_reset_prep()) + ehci->debug = NULL; + else + dbgp_external_startup(); + } + /* Ideally and we've got a real resume here, and no port's power * was lost. (For PCI, that means Vaux was maintained.) But we * could instead be restoring a swsusp snapshot -- so that BIOS was -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/