Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755370AbZGDJvC (ORCPT ); Sat, 4 Jul 2009 05:51:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753617AbZGDJux (ORCPT ); Sat, 4 Jul 2009 05:50:53 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:39511 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815AbZGDJuw (ORCPT ); Sat, 4 Jul 2009 05:50:52 -0400 Date: Sat, 4 Jul 2009 11:50:23 +0200 From: Ingo Molnar To: Jaswinder Singh Rajput Cc: Arjan van de Ven , Paul Mackerras , Benjamin Herrenschmidt , Anton Blanchard , Thomas Gleixner , Peter Zijlstra , x86 maintainers , LKML , Alan Cox Subject: Re: [PATCH 3/3 -tip] perf list: avoid replicating functions Message-ID: <20090704095023.GB2139@elte.hu> References: <1246440977.3403.7.camel@hpdv5.satnam> <1246441043.3403.9.camel@hpdv5.satnam> <20090701112007.GD15958@elte.hu> <20090701112704.GF15958@elte.hu> <1246448441.6940.3.camel@hpdv5.satnam> <20090701114928.GI15958@elte.hu> <1246527872.13659.2.camel@hpdv5.satnam> <1246606736.2322.9.camel@jaswinder.satnam> <20090703093032.GI3902@elte.hu> <1246623441.2322.36.camel@jaswinder.satnam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1246623441.2322.36.camel@jaswinder.satnam> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -0.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-0.5 required=5.9 tests=BAYES_00,FS_REPLICA autolearn=no SpamAssassin version=3.2.5 1.0 FS_REPLICA Subject says "replica" -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2116 Lines: 48 * Jaswinder Singh Rajput wrote: > On Fri, 2009-07-03 at 11:30 +0200, Ingo Molnar wrote: > > * Jaswinder Singh Rajput wrote: > > > > > > $ ./perf list shows vector events like : > > > > > > > > vec-adds OR add [Hardware vector event] > > > > vec-muls OR multiply [Hardware vector event] > > > > vec-divs OR divide [Hardware vector event] > > > > vec-idle-cycles OR vec-empty-cycles [Hardware vector event] > > > > vec-stall-cycles OR vec-busy-cycles [Hardware vector event] > > > > vec-ops OR vec-operations [Hardware vector event] > > > > btw., why does this printout SHOUT the 'or'? It's certainly not an > > important piece of information. Something like: > > > > vec-adds | add [Hardware vector event] > > vec-muls | multiply [Hardware vector event] > > vec-divs | divide [Hardware vector event] > > vec-idle-cycles | vec-empty-cycles [Hardware vector event] > > vec-stall-cycles | vec-busy-cycles [Hardware vector event] > > vec-ops | vec-operations [Hardware vector event] > > > > looks better on all levels. > > > > I prepared this patch incrementally on : > [PATCH 1/2 -tip] perf_counter: Add generalized hardware vectored co-processor support for AMD and Intel Corei7/Nehalem > [PATCH 2/2 -tip] perf_counter: Add generalized hardware interrupt support for AMD and Intel Corei7/Nehalem, Core2 and Atom > > [PATCH 3/3] perf list: avoid replicating functions > > vector and interrupt can use same function made for hardware and > software generic events. > > Also replaced 'OR' with '|' Please submit a clean series of patches instead of a mixture of patches plus fixes to patches. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/