Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753264AbZIAInH (ORCPT ); Tue, 1 Sep 2009 04:43:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753107AbZIAInG (ORCPT ); Tue, 1 Sep 2009 04:43:06 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]:17459 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbZIAInE (ORCPT ); Tue, 1 Sep 2009 04:43:04 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=rPMWngLd3cYP6k83cFDfJGuI2HVyZbAXkwsgjywn5lvfeM7g1s6YNwyli7rk5twveQ 72yvF3n15CT2Hun/Tr8YSGx359hJYcOW9Z0voNCq6wApDYZyx5/oWp2ZDkaAPv7djH2O vqxuEBylt+bolk5mA7+OH2jZgN0Fg8Ui2UDwM= MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 1 Sep 2009 12:43:06 +0400 Message-ID: Subject: Re: [Question] x86,APIC: In apicdef.h dfr,svr,...... shouldn't be const? From: Cyrill Gorcunov To: Rakib Mullick Cc: LKML , x86@kernel.org, Ingo Molnar , Yinghai Lu Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 32 On 9/1/09, Rakib Mullick wrote: > Hello guys, Intel System programmers guide says - dfr, svr, esr - this > registers should be readonly. So shouldn't they use const? Or is it > anything else? Hi Rakib, i dont have sources under my hands at moment, but iirc there were situations we nees to poke esr register. > > And apicdef.h also contains a style problem, checkpatch warns about > following style: > > u32 spurious_vector : 8 > > Check patch wants as: > > u32 spurious_vector:8 > > Shouldn't this issues be fixed? > > Thanks, > -- i dont see reason why not ;) though i wonder why we need this structure at all. We may have extended amd entries. Yinghai cced. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/