Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbZIAItM (ORCPT ); Tue, 1 Sep 2009 04:49:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753178AbZIAItL (ORCPT ); Tue, 1 Sep 2009 04:49:11 -0400 Received: from tundra.namei.org ([65.99.196.166]:38382 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbZIAItK (ORCPT ); Tue, 1 Sep 2009 04:49:10 -0400 Date: Tue, 1 Sep 2009 18:48:25 +1000 (EST) From: James Morris To: Jiri Slaby cc: Andrew Morton , mingo@redhat.com, oleg@redhat.com, linux-kernel@vger.kernel.org, Stephen Smalley , Eric Paris , David Howells , linux-security-module@vger.kernel.org, Frank Mayhar Subject: Re: [PATCH 1/6] SECURITY: selinux, fix update_rlimit_cpu parameter In-Reply-To: <4A9CBD22.1050401@gmail.com> Message-ID: References: <1251744974-29398-1-git-send-email-jirislaby@gmail.com> <4A9CBD22.1050401@gmail.com> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 26 On Tue, 1 Sep 2009, Jiri Slaby wrote: > > This doesn't look correct to me: the original code determines > > rlim->rlim_cur and then updates current to that. With your change, this > > value is not used. > > No, the for loop is to alter all limits according to the init limits. Ahh, ok, I misread the code. > > update_rlimit_cpu is called for RLIMIT_CPU to annotate scheduler about > CPU time changes (if any). > > BTW this was introduced by f06febc96ba8e0af80bcc3eaec0a109e88275fac > (timers: fix itimer/many thread hang). > -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/