Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753566AbZIAJwP (ORCPT ); Tue, 1 Sep 2009 05:52:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752932AbZIAJwO (ORCPT ); Tue, 1 Sep 2009 05:52:14 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:38921 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752444AbZIAJwN (ORCPT ); Tue, 1 Sep 2009 05:52:13 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Date: Tue, 1 Sep 2009 18:50:13 +0900 From: KAMEZAWA Hiroyuki To: Hugh Dickins Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, "linux-mm@kvack.org" , hannes@cmpxchg.org Subject: Re: [mmotm][BUG] free is bigger than presnet Re: mmotm 2009-08-27-16-51 uploaded Message-Id: <20090901185013.c86bd937.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: References: <200908272355.n7RNtghC019990@imap1.linux-foundation.org> <20090901180032.55f7b8ca.kamezawa.hiroyu@jp.fujitsu.com> Organization: FUJITSU Co. LTD. X-Mailer: Sylpheed 2.5.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1981 Lines: 56 On Tue, 1 Sep 2009 10:33:31 +0100 (BST) Hugh Dickins wrote: > On Tue, 1 Sep 2009, KAMEZAWA Hiroyuki wrote: > > > > I'm not digggin so much but /proc/meminfo corrupted. > > > > [kamezawa@bluextal cgroup]$ cat /proc/meminfo > > MemTotal: 24421124 kB > > MemFree: 38314388 kB > > If that's without my fix to shrink_active_list(), I'd try again with. > Hugh > Thank you very much. I missed this patch. It's fixed. Regards, -Kame > [PATCH mmotm] vmscan move pgdeactivate modification to shrink_active_list fix > > mmotm 2009-08-27-16-51 lets the OOM killer loose on my loads even > quicker than last time: one bug fixed but another bug introduced. > vmscan-move-pgdeactivate-modification-to-shrink_active_list.patch > forgot to add NR_LRU_BASE to lru index to make zone_page_state index. > > Signed-off-by: Hugh Dickins > --- > > mm/vmscan.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > --- mmotm/mm/vmscan.c 2009-08-28 10:07:57.000000000 +0100 > +++ linux/mm/vmscan.c 2009-08-28 18:30:33.000000000 +0100 > @@ -1381,8 +1381,10 @@ static void shrink_active_list(unsigned > reclaim_stat->recent_rotated[file] += nr_rotated; > __count_vm_events(PGDEACTIVATE, nr_deactivated); > __mod_zone_page_state(zone, NR_ISOLATED_ANON + file, -nr_taken); > - __mod_zone_page_state(zone, LRU_ACTIVE + file * LRU_FILE, nr_rotated); > - __mod_zone_page_state(zone, LRU_BASE + file * LRU_FILE, nr_deactivated); > + __mod_zone_page_state(zone, NR_ACTIVE_ANON + file * LRU_FILE, > + nr_rotated); > + __mod_zone_page_state(zone, NR_INACTIVE_ANON + file * LRU_FILE, > + nr_deactivated); > spin_unlock_irq(&zone->lru_lock); > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/