Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755019AbZIAQ4Z (ORCPT ); Tue, 1 Sep 2009 12:56:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754699AbZIAQ4Z (ORCPT ); Tue, 1 Sep 2009 12:56:25 -0400 Received: from hera.kernel.org ([140.211.167.34]:55440 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752582AbZIAQ4Y (ORCPT ); Tue, 1 Sep 2009 12:56:24 -0400 Message-ID: <4A9D5206.5010603@kernel.org> Date: Tue, 01 Sep 2009 09:55:34 -0700 From: Yinghai Lu User-Agent: Thunderbird 2.0.0.22 (X11/20090605) MIME-Version: 1.0 To: Ingo Molnar CC: Jesse Barnes , Thomas Gleixner , "H. Peter Anvin" , linux-kernel@vger.kernel.org, Jesse Brandeburg Subject: Re: [PATCH] x86/PCI: initialize PCI bus node numbers early References: <20090710104419.0032be7b@jbarnes-g45> <20090901135358.GA31282@elte.hu> In-Reply-To: <20090901135358.GA31282@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1739 Lines: 44 Ingo Molnar wrote: > * Jesse Barnes wrote: > >> The current mp_bus_to_node array is initialized only by AMD specific >> code, since AMD platforms have registers that can be used for >> determining mode numbers. On new Intel platforms it's necessary to >> initialize this array as well though, otherwise all PCI node numbers >> will be 0, when in fact they should be -1 (indicating that I/O isn't >> tied to any particular node). >> >> So move the mp_bus_to_node code into the common PCI code, and >> initialize it early with a default value of -1. This may be overridden >> later by arch code (e.g. the AMD code). >> >> With this change, PCI consistent memory and other node specific >> allocations (e.g. skbuff allocs) should occur on the "current" node. >> If, for performance reasons, applications want to be bound to specific >> nodes, they should open their devices only after being pinned to the >> CPU where they'll run, for maximum locality. >> >> Any thoughts here Yinghai or Jesse? >> >> >> include/asm/pci.h | 2 + >> kernel/setup.c | 2 + >> pci/amd_bus.c | 61 +----------------------------------------- >> pci/common.c | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 83 insertions(+), 59 deletions(-) > > FYI, this commit: > > acccaba: x86/PCI: initialize PCI bus node numbers early > > caused a boot crash in -tip testing: > looks like the patch change default 0 in 32bit to -1 ... YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/