DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=gDpwfM0w1LUlvei9TpgkvmzRq9J9cKIzI0TM1rFny3KQQVjf9p6BENwPUikqLafHgEsgif6libpD8ZiUpgYjE1a7ltCxjbQshSem+Gmfi3jtafYQcrBiHt23dEar/WWME2oqpAW64sI3l+aMFuiQ6A0NDtFfOvK51DoS/whtjBY=  ;
From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 2.6.31-rc7] gpiolib: allow poll() on value
Date: Tue, 1 Sep 2009 18:04:10 -0700
User-Agent: KMail/1.9.10
Cc: linux-kernel@vger.kernel.org, dg@emlix.com
References: <200908271650.59287.david-b@pacbell.net> <20090901134311.95fba3c8.akpm@linux-foundation.org>
In-Reply-To: <20090901134311.95fba3c8.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200909011804.10934.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1047
Lines: 34

On Tuesday 01 September 2009, Andrew Morton wrote:
> > ...
> >
> > +static struct idr pdesc_idr;
> 
> There's no locking to protect this tree. ?If that isn't a bug then I'd
> suggest that a comment be added here explaining why.

Covered by mutex_lock(&sysfs_lock) calls per a quick re-read...


> > +static irqreturn_t gpio_sysfs_irq(int irq, void *priv)
> > +{
> > +?????struct work_struct??????*work = priv;
> > +
> > +?????schedule_work(work);
> > +?????return IRQ_HANDLED;
> > +}
> 
> The only place where we explicitly cancel the pending work is in
> gpio_setup_irq(). ?Is that sufficient? ?Is there any way in which the
> work callback can occur after things have been
> freed/closed/deinitialised/etc?

Not that I noticed; it's not supposed to be possible to
free/etc with IRQs active.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/