Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755643AbZIBDMe (ORCPT ); Tue, 1 Sep 2009 23:12:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755611AbZIBDMe (ORCPT ); Tue, 1 Sep 2009 23:12:34 -0400 Received: from mail-px0-f204.google.com ([209.85.216.204]:65519 "EHLO mail-px0-f204.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755592AbZIBDMd convert rfc822-to-8bit (ORCPT ); Tue, 1 Sep 2009 23:12:33 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=UVSB+IY8WJ2msi5AHARuh/g2oxJLdz/TGYeotMS0GFlZ7QKkIFEe7CZLplNcRXJukx exm3IKX6qqvK9u5OpRVPMQ1Ia8Mcj2NZdpXfadhDSpgbl3CJQc5a2wjwYgJA6iNymdgP BBeXTsdg3Z4p910gedsxEw9dwbtC42f2bba8Y= MIME-Version: 1.0 In-Reply-To: <20090902095912.cdf8a55e.kamezawa.hiroyu@jp.fujitsu.com> References: <4A9C09BE.4060404@redhat.com> <20090831185640.GF3758@redhat.com> <20090901.160004.226800357.ryov@valinux.co.jp> <20090901141142.GA13709@redhat.com> <20090902095912.cdf8a55e.kamezawa.hiroyu@jp.fujitsu.com> Date: Wed, 2 Sep 2009 08:42:34 +0530 X-Google-Sender-Auth: 813c9b68948d23c7 Message-ID: <661de9470909012012u4c4b5e50g816a524262642b1e@mail.gmail.com> Subject: Re: [PATCH 18/23] io-controller: blkio_cgroup patches from Ryo to track async bios. From: Balbir Singh To: KAMEZAWA Hiroyuki Cc: Vivek Goyal , Ryo Tsuruta , dhaval@linux.vnet.ibm.com, dm-devel@redhat.com, jens.axboe@oracle.com, agk@redhat.com, paolo.valente@unimore.it, jmarchan@redhat.com, fernando@oss.ntt.co.jp, jmoyer@redhat.com, mingo@elte.hu, riel@redhat.com, fchecconi@gmail.com, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, righi.andrea@gmail.com, torvalds@linux-foundation.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1707 Lines: 38 On Wed, Sep 2, 2009 at 6:29 AM, KAMEZAWA Hiroyuki wrote: > On Tue, 1 Sep 2009 10:11:42 -0400 > Vivek Goyal wrote: >> > > > - Somebody also gave an example where there is a memory hogging process and >> > > > ?possibly pushes out some processes to swap. It does not sound fair to >> > > > ?charge those proccess for that swap writeout. These processes never >> > > > ?requested swap IO. >> > >> > I think that swap writeouts should be charged to the memory hogging >> > process, because the process consumes more resources and it should get >> > a penalty. >> > >> >> A process requesting memory gets IO penalty? IMHO, swapping is a kernel >> mechanism and kernel's way of providing extended RAM. If we want to solve >> the issue of memory hogging by a process then right way to solve is to use >> memory controller and not by charging the process for IO activity. >> Instead, proabably a more suitable way is to charge swap activity to root >> group (where by default all the kernel related activity goes). >> > > I agree. It't memcg's job. > (Support dirty_ratio in memcg is necessary, I think) > > background-write-out-to-swap-for-memory-shortage should be handled > as kernel I/O. If swap-out-by-memcg bacause of its limit is a problem, > dirty_ratio for memcg should be implemetned. I tend to agree, looks like dirty_ratio will become important along with overcommit support in the future. Balbir Singh. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/