From: Ed Cashin <ecashin@coraid.com>
Date: Wed, 2 Sep 2009 09:31:49 -0400
To: bonbons@linux-vserver.org, ecashin@coraid.com, apw@canonical.com,
       akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] aoe: ensure we initialise the request_queue correctly
Message-ID: <515b4651c5aa3f5bc550b26fe708f65d@coraid.com>
In-Reply-To: <20090901223128.4bf1bf53@neptune.home>
References: <1250872904-10993-1-git-send-email-apw@canonical.com>
	<9ab0e087296715d764071d4d39542985@coraid.com>
	<20090829154305.723fd86c@neptune.home>
	<6309cc7d77486e24aca5130ec5802dfb@coraid.com>
	<20090901223128.4bf1bf53@neptune.home>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1454
Lines: 37

On Tue Sep  1 16:31:58 EDT 2009, bonbons@linux-vserver.org wrote:
> On Tue, 01 September 2009 Ed Cashin <ecashin@coraid.com> wrote:
...
> > Thanks much for doing that.  It makes sense that this change would
> > have caused it to suddenly matter whether the unused queue is
> > initialized.
> > 
> > The patch looks fine to me.
> 
> Would it make sense to fine-tune the values reported by sys-fs in the
> queue details so they match with the AoE device (as a separate
> enhancement patch)?
> 
> Sure the queue itself won't use them, but some user-space tools might
> be interested in this data.
> 
> I've not checked what information is provided by AoE protocol or can
> be deducted from interface MTU.

The AoE protocol does allow a storage target to say, "I can handle
this certain number of sectors in a single read or write command." But
the user space tools cannot really benefit from that information,
since they can send larger read/write operations with no loss of
efficiency.

So I suspect that it would not make much sense, but if you decide to
look into it further, see whether you can identify an extant user
space tool that benefits from the information.

-- 
  Ed Cashin
  http://noserose.net/e/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/