Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753489AbZIBUCI (ORCPT ); Wed, 2 Sep 2009 16:02:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753467AbZIBUCH (ORCPT ); Wed, 2 Sep 2009 16:02:07 -0400 Received: from hq-exedge.brocade.com ([66.243.153.82]:21438 "EHLO hq-exedge.brocade.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753462AbZIBUCG convert rfc822-to-8bit (ORCPT ); Wed, 2 Sep 2009 16:02:06 -0400 From: Jing Huang To: Andrew Morton CC: "James.Bottomley@HansenPartnership.com" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , Ramkumar Vadivelu , Vinodh Ravindran Date: Wed, 2 Sep 2009 13:02:07 -0700 Subject: RE: [PATCH 1/14] bfa: Brocade BFA FC SCSI driver (bfad) Thread-Topic: [PATCH 1/14] bfa: Brocade BFA FC SCSI driver (bfad) Thread-Index: AcosBXNVYwgBuL2dRzqdCbiZHKY6zAAAiU2w Message-ID: References: <200908280754.n7S7sUMB030191@blc-10-6.brocade.com> <20090902124135.aa55f0be.akpm@linux-foundation.org> In-Reply-To: <20090902124135.aa55f0be.akpm@linux-foundation.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1555 Lines: 45 > These patches seem to have been posted a lot of times. Is anyone > paying attention? > > > +BFA_TRC_FILE(LDRV, BFAD); > > + > > +static DEFINE_MUTEX(bfad_mutex); > > +int bfad_scan_done; > > + > > +LIST_HEAD(bfad_list); > > + > > +static int bfad_inst; > > +int supported_fc4s; > > + > > +char *host_name; > > +char *os_name; > > +char *os_patch; > > +int num_rports; > > +int num_ios; > > +int num_tms; > > +int num_fcxps; > > +int num_ufbufs; > > +int reqq_size; > > +int rspq_size; > > +int num_sgpgs; > > +int rport_del_timeout = BFA_FCS_RPORT_DEF_DEL_TIMEOUT; > > +int bfa_lun_queue_depth = BFAD_LUN_QUEUE_DEPTH; > > +int bfa_io_max_sge = BFAD_IO_MAX_SGE; > > +int log_level = BFA_LOG_WARNING; > > +int ioc_auto_recover = BFA_TRUE; > > +int ipfc_enable = BFA_FALSE; > > +int ipfc_mtu = -1; > > +int linkup_delay = -1; > > eek. These are all kernel-wide global symbols and many of them are > very inappropriately named. They should either be made static or given > a subsystem-specific prefix such as "bfad_". > Thanks Andrew. I will fix this and resubmit. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/