Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751661AbZICMY0 (ORCPT ); Thu, 3 Sep 2009 08:24:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751325AbZICMY0 (ORCPT ); Thu, 3 Sep 2009 08:24:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13273 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885AbZICMYZ (ORCPT ); Thu, 3 Sep 2009 08:24:25 -0400 Date: Thu, 3 Sep 2009 14:27:08 +0200 From: Michal Schmidt To: linux-scsi@vger.kernel.org Cc: Bob Tracy , linux-kernel@vger.kernel.org, stable@kernel.org Subject: [PATCH] sg: fix oops in the error path in sg_build_indirect() Message-ID: <20090903142708.0b820ca1@leela> In-Reply-To: <20090903033945.GA20755@gherkin.frus.com> References: <20090903033945.GA20755@gherkin.frus.com> Organization: Red Hat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 785 Lines: 25 When the allocation fails in sg_build_indirect(), an oops happens in the error path. It's caused by an obvious typo. Signed-off-by: Michal Schmidt Reported-by: Bob Tracy --- diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 9230402..4968c4c 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1811,7 +1811,7 @@ retry: return 0; out: for (i = 0; i < k; i++) - __free_pages(schp->pages[k], order); + __free_pages(schp->pages[i], order); if (--order >= 0) goto retry; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/