Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753021AbZICNrW (ORCPT ); Thu, 3 Sep 2009 09:47:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755334AbZICNrU (ORCPT ); Thu, 3 Sep 2009 09:47:20 -0400 Received: from gw1.cosmosbay.com ([212.99.114.194]:47156 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755333AbZICNrR (ORCPT ); Thu, 3 Sep 2009 09:47:17 -0400 Message-ID: <4A9FC8B1.904@gmail.com> Date: Thu, 03 Sep 2009 15:46:25 +0200 From: Eric Dumazet User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Zdenek Kabelac CC: Patrick McHardy , Christoph Lameter , Robin Holt , Linux Kernel Mailing List , Pekka Enberg , Jesper Dangaard Brouer , Linux Netdev List , Netfilter Developers Subject: Re: [PATCH] slub: fix slab_pad_check() and SLAB_DESTROY_BY_RCU References: <4A87CE60.4020506@gmail.com> <4A896324.3040104@trash.net> <4A9EEF07.5070800@gmail.com> <4A9F1620.2080105@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gw1.cosmosbay.com [0.0.0.0]); Thu, 03 Sep 2009 15:46:25 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 34 Zdenek Kabelac a ?crit : > 2009/9/3 Eric Dumazet : >> Zdenek Kabelac a ?crit : >>> Well I'm not noticing any ill behavior - also note - rcu_barrier() is >>> there before the cache is destroyed. >>> But as I said - it's just my shot into the dark - which seems to work for me... >>> >> Reading again your traces, I do believe there are two bugs in slub >> >> Maybe not explaining your problem, but worth to fix ! >> >> Thank you >> >> [PATCH] slub: fix slab_pad_check() and SLAB_DESTROY_BY_RCU >> > > > Ok - I can confirm that this patch fixes my reboot problem. > > Thanks > > Zdenek Good news ! Hmm... but you had a problem with a 2.6.29.something kernel if I remember well ? At that time, conntrack did not use SLAB_DESTROY_BY_RCU yet. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/