Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932073AbZICOFc (ORCPT ); Thu, 3 Sep 2009 10:05:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755316AbZICOFb (ORCPT ); Thu, 3 Sep 2009 10:05:31 -0400 Received: from mail-bw0-f219.google.com ([209.85.218.219]:60703 "EHLO mail-bw0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754497AbZICOF3 (ORCPT ); Thu, 3 Sep 2009 10:05:29 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=IzKnUjZrwitfe+Cg7M/mXuwSOibd6v/QhKCQbr+oT8n+lkhy6mIxOAdjFelG0MJfJR NhslZr6ElZwm5aCy43nXa/+l2xbeng+vI3ckboOu9aWnS0LVTorMh+pyQFBDEXNyw7q3 tKtb4e5HIJ4lSFmsLn1PC3DgEyirlCgzbLsj8= MIME-Version: 1.0 In-Reply-To: References: <4A896324.3040104@trash.net> <4A9EEF07.5070800@gmail.com> <4A9F1620.2080105@gmail.com> <84144f020909022331x2b275aa5n428f88670e0ae8bc@mail.gmail.com> <4A9F7283.1090306@gmail.com> <84144f020909030051u6cf6ae01he25c268f718ff3af@mail.gmail.com> Date: Thu, 3 Sep 2009 17:05:30 +0300 X-Google-Sender-Auth: 70f942cb88801efc Message-ID: <84144f020909030705x7909cf07w7ea0d3662a66c5cc@mail.gmail.com> Subject: Re: [PATCH] slub: fix slab_pad_check() and SLAB_DESTROY_BY_RCU From: Pekka Enberg To: Christoph Lameter Cc: Eric Dumazet , Zdenek Kabelac , Patrick McHardy , Robin Holt , Linux Kernel Mailing List , Jesper Dangaard Brouer , Linux Netdev List , Netfilter Developers , paulmck@linux.vnet.ibm.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1158 Lines: 30 Hi Christoph, On Thu, 3 Sep 2009, Pekka Enberg wrote: >> Oh, sure, the fix looks sane to me. It's just that I am a complete >> coward when it comes to merging RCU related patches so I always try to >> fish an Acked-by from Paul or Christoph ;). On Thu, Sep 3, 2009 at 8:50 PM, Christoph Lameter wrote: > I am fine with acking the poison piece. Ok. On Thu, Sep 3, 2009 at 8:50 PM, Christoph Lameter wrote: > I did not ack the patch that added rcu to kmem_cache_destroy() and I > likely wont ack that piece either. Right. I didn't remember that I merged that over your NAK but I don't share your view that kmem_cache_destroy() callers should do rcu_barrier() or whatever is necessary if we can do it from kmem_cache_destroy(). So I am happy to take both changes but I would appreciate them being split into two separate patches. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/