Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754645AbZICOfL (ORCPT ); Thu, 3 Sep 2009 10:35:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754529AbZICOfK (ORCPT ); Thu, 3 Sep 2009 10:35:10 -0400 Received: from mail-fx0-f217.google.com ([209.85.220.217]:39233 "EHLO mail-fx0-f217.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754222AbZICOfH convert rfc822-to-8bit (ORCPT ); Thu, 3 Sep 2009 10:35:07 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=oXtiSVhafipj+QqTIsWgweX1eZfgg03mqC7sCbL1ELHxeEK+EAnXa7VN6A0+mEeE5b Cba49MM7jJ8n9h3eL8QFSUcH12rJOaZk2ZsCIqe01wrP8szJrX/xnrtVYoAQNFsFOU+P kMlsw4csAO6su3cdmGEzLvMBIuxLZu+jfP3Ns= MIME-Version: 1.0 In-Reply-To: <4A9FC8B1.904@gmail.com> References: <4A87CE60.4020506@gmail.com> <4A896324.3040104@trash.net> <4A9EEF07.5070800@gmail.com> <4A9F1620.2080105@gmail.com> <4A9FC8B1.904@gmail.com> Date: Thu, 3 Sep 2009 16:35:08 +0200 Message-ID: Subject: Re: [PATCH] slub: fix slab_pad_check() and SLAB_DESTROY_BY_RCU From: Zdenek Kabelac To: Eric Dumazet Cc: Patrick McHardy , Christoph Lameter , Robin Holt , Linux Kernel Mailing List , Pekka Enberg , Jesper Dangaard Brouer , Linux Netdev List , Netfilter Developers Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 43 2009/9/3 Eric Dumazet : > Zdenek Kabelac a ?crit : >> 2009/9/3 Eric Dumazet : >>> Zdenek Kabelac a ?crit : >>>> Well I'm not noticing any ill behavior - also note - rcu_barrier() is >>>> there before the cache is destroyed. >>>> But as I said - it's just my shot into the dark - which seems to work for me... >>>> >>> Reading again your traces, I do believe there are two bugs in slub >>> >>> Maybe not explaining your problem, but worth to fix ! >>> >>> Thank you >>> >>> [PATCH] slub: fix slab_pad_check() and SLAB_DESTROY_BY_RCU >>> >> >> >> Ok - I can confirm that this patch fixes my reboot problem. >> >> Thanks >> >> Zdenek > > Good news ! > > Hmm... but you had a problem with a 2.6.29.something kernel if I remember well ? > > At that time, conntrack did not use SLAB_DESTROY_BY_RCU yet. Yes - but it was also giving different error message - which even not loaded ftp conntrack module. Basically it has been fine until conntrack started to use rcu. From that moment various errors started to appear with slub and some kernel debugging options - slab was fine. With your recent patch it's the first time I do not see oops with nf after 2.6.29 kernel. Zdenek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/