Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755855AbZICPLw (ORCPT ); Thu, 3 Sep 2009 11:11:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755827AbZICPLv (ORCPT ); Thu, 3 Sep 2009 11:11:51 -0400 Received: from c60.cesmail.net ([216.154.195.49]:4369 "EHLO c60.cesmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755319AbZICPLt (ORCPT ); Thu, 3 Sep 2009 11:11:49 -0400 Subject: Re: [PATCH] rt2x00: Get rid of duplicate usb id from rt2500usb From: Pavel Roskin To: Ivo Van Doorn Cc: "John W. Linville" , Amit Kucheria , List Linux Kernel , linux-wireless@vger.kernel.org In-Reply-To: References: <1251978140-4992-1-git-send-email-amit.kucheria@canonical.com> <20090903115521.GB12597@tuxdriver.com> Content-Type: text/plain Date: Thu, 03 Sep 2009 11:11:39 -0400 Message-Id: <1251990699.6521.12.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1428 Lines: 32 On Thu, 2009-09-03 at 16:18 +0200, Ivo Van Doorn wrote: > On Thu, Sep 3, 2009 at 1:55 PM, John W. Linville wrote: > > On Thu, Sep 03, 2009 at 02:42:20PM +0300, Amit Kucheria wrote: > >> USB_DEVICE(0x148f, 0x2573) is served by the rt73usb driver where it is already > >> defined. Remove it from rt2500usb. > >> > >> Signed-off-by: Amit Kucheria > >> Cc: Ivo van Doorn > > > > IIRC there are IDs that are used by different devices where rt73usb > > covers one device and the rt2500usb covers another. Are you sure > > this is not one of those? > > Yes, I believe this particular ID was already discussed some time ago > on this list. This is one of the infamous duplicate IDs. (Fortunately not > one of those infamous Linksys devices with 5 different chipsets for the > same ID). The famous Linksys devices can be distinguished by the textual PCMCIA ID. In this case, there is no reliable way to distinguish the devices without trying the drivers. I tried and could not find any difference between "lsusb -v" output for the devices said to be supported by rt2500usb and rt73usb. -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/