Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755457AbZICPtk (ORCPT ); Thu, 3 Sep 2009 11:49:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753559AbZICPtj (ORCPT ); Thu, 3 Sep 2009 11:49:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18384 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753328AbZICPtj (ORCPT ); Thu, 3 Sep 2009 11:49:39 -0400 Subject: [PATCH resend] block: silently error unsupported empty barriers too From: Mark McLoughlin Reply-To: Mark McLoughlin To: Jens Axboe Cc: linux-kernel , virtualization , dm-devel , Rusty Russell , Mikulas Patocka , Alasdair Kergon , Neil Brown , Christoph Hellwig Content-Type: text/plain Date: Thu, 03 Sep 2009 16:47:50 +0100 Message-Id: <1251992870.3084.125.camel@blaa> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1624 Lines: 51 With 2.6.31-rc5 in a KVM guest using dm and virtio_blk, we see the following errors: end_request: I/O error, dev vda, sector 0 end_request: I/O error, dev vda, sector 0 The errors go away if dm stops submitting empty barriers, by reverting: commit 52b1fd5a27c625c78373e024bf570af3c9d44a79 Author: Mikulas Patocka dm: send empty barriers to targets in dm_flush We should error all barriers, even empty barriers, on devices like virtio_blk which don't support them. See also: https://bugzilla.redhat.com/514901 Signed-off-by: Mark McLoughlin Cc: Rusty Russell Cc: Mikulas Patocka Cc: Alasdair G Kergon Cc: Neil Brown Cc: Christoph Hellwig --- block/blk-core.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index e3299a7..35ad2bb 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1163,8 +1163,7 @@ static int __make_request(struct request_queue *q, struct bio *bio) const int unplug = bio_unplug(bio); int rw_flags; - if (bio_barrier(bio) && bio_has_data(bio) && - (q->next_ordered == QUEUE_ORDERED_NONE)) { + if (bio_barrier(bio) && (q->next_ordered == QUEUE_ORDERED_NONE)) { bio_endio(bio, -EOPNOTSUPP); return 0; } -- 1.6.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/