Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755363AbZICNsF (ORCPT ); Thu, 3 Sep 2009 09:48:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755307AbZICNsE (ORCPT ); Thu, 3 Sep 2009 09:48:04 -0400 Received: from smtp2.ultrahosting.com ([74.213.174.253]:37132 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755243AbZICNsC (ORCPT ); Thu, 3 Sep 2009 09:48:02 -0400 Date: Thu, 3 Sep 2009 12:45:43 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@V090114053VZO-1 To: Eric Dumazet cc: Pekka Enberg , Zdenek Kabelac , Patrick McHardy , Robin Holt , Linux Kernel Mailing List , Jesper Dangaard Brouer , Linux Netdev List , Netfilter Developers , paulmck@linux.vnet.ibm.com Subject: Re: [PATCH] slub: fix slab_pad_check() and SLAB_DESTROY_BY_RCU In-Reply-To: <4A9F7283.1090306@gmail.com> Message-ID: References: <4A87CE60.4020506@gmail.com> <4A896324.3040104@trash.net> <4A9EEF07.5070800@gmail.com> <4A9F1620.2080105@gmail.com> <84144f020909022331x2b275aa5n428f88670e0ae8bc@mail.gmail.com> <4A9F7283.1090306@gmail.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 654 Lines: 16 On Thu, 3 Sep 2009, Eric Dumazet wrote: > on a SLAB_DESTROY_BY_RCU cache, there is no need to try to optimize this > rcu_barrier() call, unless we want superfast reboot/halt sequences... I stilll think that the action to quiesce rcu is something that the caller of kmem_cache_destroy must take care of. Could you split this into two patches: One that addresses the poison and another that deals with rcu? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/