Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756255AbZICT5p (ORCPT ); Thu, 3 Sep 2009 15:57:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756235AbZICT5o (ORCPT ); Thu, 3 Sep 2009 15:57:44 -0400 Received: from gw1.cosmosbay.com ([212.99.114.194]:48548 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756214AbZICT5n (ORCPT ); Thu, 3 Sep 2009 15:57:43 -0400 Message-ID: <4AA01F54.4040808@gmail.com> Date: Thu, 03 Sep 2009 21:56:04 +0200 From: Eric Dumazet User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: Pekka Enberg CC: Christoph Lameter , Zdenek Kabelac , Patrick McHardy , Robin Holt , Linux Kernel Mailing List , Jesper Dangaard Brouer , Linux Netdev List , Netfilter Developers , paulmck@linux.vnet.ibm.com, "stable@kernel.org" Subject: Re: [PATCH] slub: Fix kmem_cache_destroy() with SLAB_DESTROY_BY_RCU References: <4A9EEF07.5070800@gmail.com> <4A9F1620.2080105@gmail.com> <84144f020909022331x2b275aa5n428f88670e0ae8bc@mail.gmail.com> <4A9F7283.1090306@gmail.com> <84144f020909030051u6cf6ae01he25c268f718ff3af@mail.gmail.com> <84144f020909030705x7909cf07w7ea0d3662a66c5cc@mail.gmail.com> <4A9FD047.9000002@gmail.com> <84144f020909031248s56c16205j7992930c413b1bbe@mail.gmail.com> In-Reply-To: <84144f020909031248s56c16205j7992930c413b1bbe@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gw1.cosmosbay.com [0.0.0.0]); Thu, 03 Sep 2009 21:56:05 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1379 Lines: 35 Pekka Enberg a ?crit : > On Thu, Sep 3, 2009 at 5:18 PM, Eric Dumazet wrote: >> Here is the second patch (RCU thing). Stable candidate >> >> [PATCH] slub: Fix kmem_cache_destroy() with SLAB_DESTROY_BY_RCU >> >> kmem_cache_destroy() should call rcu_barrier() *after* kmem_cache_close() >> and *before* sysfs_slab_remove() or risk rcu_free_slab() >> being called after kmem_cache is deleted (kfreed). >> >> rmmod nf_conntrack can crash the machine because it has to >> kmem_cache_destroy() a SLAB_DESTROY_BY_RCU enabled cache. > > Do we have a bugzilla URL for this? Well, I can crash my 2.6.30.5 machine just doing rmmod nf_conntrack (You'll need CONFIG_SLUB_DEBUG_ON or equivalent) Original Zdenek report : http://thread.gmane.org/gmane.linux.kernel/876016/focus=876086 > >> Reported-by: Zdenek Kabelac >> Signed-off-by: Eric Dumazet >> Acked-by: Paul E. McKenney > > OK, this is in for-next now and queued for 2.6.31. If you guys want to > fix this in a different way, lets do that in 2.6.32. Seems the right thing IMHO -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/