Date: Fri, 4 Sep 2009 07:04:28 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: linux-kernel@vger.kernel.org, James Bottomley <James.Bottomley@suse.de>,
       Rusty Russell <rusty@rustcorp.com.au>, Helge Deller <deller@gmx.de>,
       Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] fix "no member named 'sect_attrs' of strcut module"
Message-ID: <20090904050428.GB8382@elte.hu>
References: <1252036108-24221-1-git-send-email-wuzhangjin@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1252036108-24221-1-git-send-email-wuzhangjin@gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1034
Lines: 30


* Wu Zhangjin <wuzhangjin@gmail.com> wrote:

> From: Wu Zhangjin <wuzhangjin@gmail.com>
> 
> The commit(1b364bf438cf337a3818aee77d68c0713f3e1fc4, "module: workaround
> duplicate section names") introduced a condition to avoid null pointer
> reference:
> 
> -       add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
> +       if (mod->sect_attrs)
> +               add_notes_attrs(mod, hdr->e_shnum, secstrings, sechdrs);
> 
> but sect_attrs is only defined when CONFIG_KALLSYMS enabled, so this
> patch is need to fix the following error:
> 
> error: 'struct module' has no member named 'sect_attrs'
> 
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>

This has been fixed already, see this upstream fix:

  ea6bff3: modules: Fix build error in the !CONFIG_KALLSYMS case

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/