Date: Fri, 4 Sep 2009 09:06:33 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: David Miller <davem@davemloft.net>, rostedt@goodmis.org,
       nhorman@tuxdriver.com, fweisbec@gmail.com, yjwei@cn.fujitsu.com,
       netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] tracing/events: convert NAPI's tracepoint via
	TRACE_EVENT
Message-ID: <20090904070633.GF29829@elte.hu>
References: <4A9B6AA7.5020508@cn.fujitsu.com> <20090831084922.GB25811@elte.hu> <alpine.DEB.2.00.0908311407060.13931@gandalf.stny.rr.com> <20090901.182645.153420711.davem@davemloft.net> <4A9DE293.6050703@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A9DE293.6050703@cn.fujitsu.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2141
Lines: 52


* Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote:

> David Miller wrote:
> 
> > This patch can't be split up, so I'm wondering how you suggest to
> > handle this patch given that you have declared that define_trace.h
> > changes aren't to go through the subsystem tree?
> > 
> > If we do the define_trace.h change only, we break the build
> > (lack of macro defined for the trace).
> > 
> > If we do only the other parts of his patch, we get a duplicate
> > definition.
> > 
> 
> This patch cooperate with my previous patch to solve the include 
> file dependencies problem. So, we do better put those two patches 
> together. (both in -tip tree or/add both in network tree)

I would not mind a duplicate commit here. Whoever merges later in 
the merge window will resolve the (easy) conflict.

David, you definitely dont want to pull the full tracing tree into 
the networking tree. It wouldnt cause technical problems in 
linux-next (Git sorts out such merges just fine and both trees are 
well tested) but it creates an unwanted merge window dependency: if 
the tracing tree's push to Linus is delayed for whatever reason the 
networking tree is delayed too. That's not really good.

It's also not good on a conceptual angle - it makes it very 
difficult for Linus to reject any of the trees, due to the mingling.

A second variant would be that we could create a mini-topic (.31-rc8 
based) in -tip with just the skb bits and the header file changes 
and once we've tested it we could push it and you could pull that 
(small, -git based) tree into the networking tree.

A third variant would be that you could do such a mini-topic branch 
yourself in the networking tree and we could pull that into the 
tracing tree.

All of these variants work fine with Steve's and my workload, it's 
up to you and Neil - you are driving the changes so do whatever is 
most convenient to you.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/