Date: Fri, 4 Sep 2009 09:19:05 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-kernel@vger.kernel.org,
       Gautham R Shenoy <ego@in.ibm.com>, Balbir Singh <balbir@in.ibm.com>
Subject: Re: [RFC][PATCH 0/8] load-balancing and cpu_power -v2
Message-ID: <20090904071905.GI29829@elte.hu>
References: <20090901083431.748830771@chello.nl> <20090903121045.GK7216@alberich.amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090903121045.GK7216@alberich.amd.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1723
Lines: 41


* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:

> On Tue, Sep 01, 2009 at 10:34:31AM +0200, Peter Zijlstra wrote:
> > A more complete version, one that compiles and mostly works on the
> > simple tests to which it was subjected.
> > 
> > It still lacks integration with APERF/MPERF because that stuff was
> > hidding in some acpi driver instead of placed in arch code for general
> > consumption.. will fix.
> > 
> > Also, SD_SHARE_CPUPOWER seems redundant in the face of sd->level ==
> > SD_LV_SIBLING, should we remove the SD_flag or depricate the level?
> > 
> > Anyway, have at it, poke holes and report issues.
> 
> Tested it (to a certain extend).
> Found no performance degradation (on 1P, 2P, 4P systems). (One could
> think performance might slightly degrade due to more frequent
> __cpu_power updates).

Ok, thanks for doing that, it's really useful - this saved me a day 
of testing and allows me to accelerate these patches and try to 
queue them up in tip:sched today.

Note, we have regressed the load-balancer in recently but its 
inherent complexity makes it pretty hard to fix. We dont max out 
kbuild performance for example - i see this in my distcc builds. 
Would be nice to sort that out too for .32, on top of Peter's 
power-balancing series.

We've got the sched-domains setup simplification suggestions from 
Peter as well, those could be done separately (but are important as 
well, to express more complex hierarchies like Magny-Cours).

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/