Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756961AbZIDPbb (ORCPT ); Fri, 4 Sep 2009 11:31:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756923AbZIDPba (ORCPT ); Fri, 4 Sep 2009 11:31:30 -0400 Received: from cinke.fazekas.hu ([195.199.244.225]:47389 "EHLO cinke.fazekas.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756927AbZIDPba (ORCPT ); Fri, 4 Sep 2009 11:31:30 -0400 Date: Fri, 4 Sep 2009 17:31:31 +0200 (CEST) From: Marton Balint To: Ingo Molnar cc: Peter Zijlstra , Andreas Mohr , linux-kernel@vger.kernel.org Subject: Re: CPU scheduler weirdness? In-Reply-To: <20090904124054.GA9490@elte.hu> Message-ID: References: <1250683834.7583.360.camel@twins> <1250707331.7154.1.camel@laptop> <20090820105645.GA23635@elte.hu> <1252053631.7564.2.camel@twins> <20090904124054.GA9490@elte.hu> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1381 Lines: 43 On Fri, 4 Sep 2009, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > >> On Thu, 2009-09-03 at 23:57 +0200, Marton Balint wrote: >>>> sched: fine-tune SD_MC_INIT: >>>> 14800984706bf6936bbec5187f736e928be5c218 >>>> >>>> If I add again the removed SD_BALANCE_NEWIDLE to flags, then everything works >>>> as expected. So what would be the correct fix for this bug? Revert the patch? >>>> Or just add SD_BALANCE_NEWIDLE to flags? >>> >>> >>> Ingo, Peter, could any of you guys have a look at the commit >>> that caused this bug? Is it OK to revert it? Or a fix somewhere >>> else is necessary? I'm pushing this because I hope that this bug >>> will get fixed in the upcoming stable kernel... >> >> I'm fine with re-adding SD_BALANCE_IDLE and SD_WAKE_IDLE on >> SMT/MC/CPU levels. >> >> Ingo? > > Ok, agreed. I have re-benchmarked a couple of key workload and it > seems like a good change, on top of your load-balancer fixes. > > Marton, could you please double check the latest -tip tree: > > http://people.redhat.com/mingo/tip.git/README > > Does it resolve the problem? Yes it does, thanks. Regards, Marton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/