Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756935AbZIDOsh (ORCPT ); Fri, 4 Sep 2009 10:48:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756912AbZIDOsf (ORCPT ); Fri, 4 Sep 2009 10:48:35 -0400 Received: from mga06.intel.com ([134.134.136.21]:61167 "EHLO orsmga101.jf.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756910AbZIDOse (ORCPT ); Fri, 4 Sep 2009 10:48:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.44,333,1249282800"; d="scan'208";a="547821295" Date: Fri, 4 Sep 2009 16:48:24 +0100 From: Alan Cox To: Alan Stern Cc: Miklos Szeredi , gregkh@suse.de, , Subject: Re: WARNINGs in usb-serial.c Message-ID: <20090904164824.391876b3@linux.intel.com> In-Reply-To: References: Organization: Intel X-Mailer: Claws Mail 3.7.2 (GTK+ 2.14.7; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1827 Lines: 51 On Fri, 4 Sep 2009 10:17:30 -0400 (EDT) Alan Stern wrote: > On Fri, 4 Sep 2009, Miklos Szeredi wrote: > > > On Thu, 3 Sep 2009, Greg KH wrote: > > > On Thu, Sep 03, 2009 at 04:13:34PM +0200, Miklos Szeredi wrote: > > > > I get the following warnings in 2.6.31-rc. A lot of them: > > > > > > > > WARNING: at drivers/usb/serial/usb-serial.c:414 > > > > serial_write_room+0x59/0x6e [usbserial]() WARNING: at > > > > drivers/usb/serial/usb-serial.c:401 serial_write+0x77/0x9d > > > > [usbserial]() > > > > > > > > This is a huawei-3565 modem. > > > > > > > > The messages don't seem to hurt, but there's lot of trouble > > > > with this gadget. Sometimes it just doesn't work after a while > > > > and a reboot is needed. Sometimes it hangs the kernel after > > > > suspend, etc. Not sure if this is related to the warnings... > > > > > > {sigh} > > > > > > The tty layer changes are being a pain here :( > > > > > > Alan Stern posted a set of patches to the linux-usb list to > > > hopefully address stuff like this, is there any way you could > > > test them out to see if they help or not? > > > > Nope, it doesn't seem to help. Still got the same warnings with the > > patched kernel (latest git + ghk tree + usbserial patches). > > What were you doing when these warnings appeared? The usual way to get it was close users = 0 ldisc processing echo write room hey we are closed Spew I suspect the actual check in write_room is now simply bogus with it all being refcounted (the ldisc will hold a tty kref at that point) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/