Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756965AbZIDPzs (ORCPT ); Fri, 4 Sep 2009 11:55:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755376AbZIDPzr (ORCPT ); Fri, 4 Sep 2009 11:55:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26057 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755290AbZIDPzq (ORCPT ); Fri, 4 Sep 2009 11:55:46 -0400 Date: Fri, 4 Sep 2009 17:49:47 +0200 From: Oleg Nesterov To: David Howells Cc: Roland McGrath , Andrew Morton , Linus Torvalds , James Morris , Tom Horsley , linux-kernel@vger.kernel.org, stable@kernel.org Subject: Re: [PATCH 1/1] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex Message-ID: <20090904154947.GA17048@redhat.com> References: <20090904133956.GA9232@redhat.com> <20090903160514.GA23646@redhat.com> <20090903200924.E46DF47C94@magilla.sf.frob.com> <32710.1252075656@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32710.1252075656@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 28 On 09/04, David Howells wrote: > > Oleg Nesterov wrote: > > > - > > - /* cred_guard_mutex must be held at least to this point to prevent > > - * ptrace_attach() from altering our determination of the task's > > - * credentials; any time after this it may be unlocked */ > > - > > Why are you removing this comment, btw? In what way does your patch > invalidate it? No, the comment is fine. Except, now we have more users of this mutex, but it only mentions ptrace_attach(). Tried to improve it, but failed to make the concise and understandable comment, I tried to collect all comments aboout cred_guard_mutex in one place, above prepare_bprm_creds()... OK, agreed. Will revert this bit and resend. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/