Date: Fri, 4 Sep 2009 20:34:04 +0400
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: pHilipp Zabel <philipp.zabel@gmail.com>
Cc: Daniel Mack <daniel@caiaq.de>, Frans Pop <elendil@planet.nl>,
       linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org,
       spyro@f2s.com, cbou@mail.ru, mreimer@vpop.net
Subject: Re: [PATCH 2/5] pda-power: switch to new dev_pm_ops
Message-ID: <20090904163404.GA26581@oksana.dev.rtsoft.ru>
Reply-To: avorontsov@ru.mvista.com
References: <1249496971-9019-1-git-send-email-daniel@caiaq.de>
 <1249496971-9019-2-git-send-email-daniel@caiaq.de>
 <200908052149.55567.elendil@planet.nl>
 <20090805222920.GF19257@buzzloop.caiaq.de>
 <74d0deb30908060452k1fc0e982jf14be2e895e9a805@mail.gmail.com>
 <20090806125631.GI19257@buzzloop.caiaq.de>
 <74d0deb30908070635s2fa76e5t954742239b8592a4@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <74d0deb30908070635s2fa76e5t954742239b8592a4@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1134
Lines: 31

On Fri, Aug 07, 2009 at 03:35:19PM +0200, pHilipp Zabel wrote:
[...]
> > +static struct dev_pm_ops pda_power_pm_ops = {
> > +       .poweroff       = pda_power_poweroff,
> > +       .restore        = pda_power_restore,
> > +};
> 
> No no, now you're missing .suspend/.resume. As I understand it, the
> suspend and hibernation codepaths are now completely separate.
> 
> Also, I'm not sure using .restore here is quite correct.
> enable_irq_wake is called in .poweroff, after .freeze + creation of
> the memory image. So if this memory image is restored during the next
> boot, there is no trace of irq wakup ever being enabled and thus no
> need to call disable_irq_wake.
> 
> I think just .suspend/.poweroff and .resume need to be used for this driver.

Daniel, any update on this patch?

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/