Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756877AbZIDRbz (ORCPT ); Fri, 4 Sep 2009 13:31:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755307AbZIDRby (ORCPT ); Fri, 4 Sep 2009 13:31:54 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:37763 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752651AbZIDRbx (ORCPT ); Fri, 4 Sep 2009 13:31:53 -0400 Date: Fri, 4 Sep 2009 07:30:43 -1000 (HST) From: Linus Torvalds To: Mikael Pettersson cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Alan Cox , Greg KH , Andrew Morton , OGAWA Hirofumi Subject: Re: [Bug #14015] pty regressed again, breaking expect and gcc's testsuite In-Reply-To: <19105.5352.28380.230615@pilspetsen.it.uu.se> Message-ID: References: <19099.52899.620345.326521@pilspetsen.it.uu.se> <19100.31254.666066.755541@pilspetsen.it.uu.se> <200909012042.59856.rjw@sisk.pl> <19105.5352.28380.230615@pilspetsen.it.uu.se> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1259 Lines: 33 On Fri, 4 Sep 2009, Mikael Pettersson wrote: > > Comparing the gcc outputs for this test case from runs with 2.6.30 and > 2.6.31-rc8 shows that 2.6.31-rc8 lost a single newline (\n) byte at byte > offset 131660. So two lines of diagnostics were fused together and the > testsuite framework failed to match the second of those lines. Goodie. That was the kind of hint I was looking for. And I suspect that that means that the bug is related to do_output_char() expanding '\n' into '\r\n'. And the different buffering (and the pty 'space' logic) just means that we now hit a case that we didn't use to hit. The relevant call chain is - n_tty handling: n_tty_write() -> process_output() -> do_output_char() -> tty_put_char(tty, '\r') tty_put_char(tty, '\n') I'll see what I can find. But your "loses \n character" does mean that the 'lost bytes at the end when the other end closed it' is probably not the issue, and we're talking about a different kind of bug entirely. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/