Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757106AbZIDReE (ORCPT ); Fri, 4 Sep 2009 13:34:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750764AbZIDReD (ORCPT ); Fri, 4 Sep 2009 13:34:03 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:35423 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755369AbZIDReB (ORCPT ); Fri, 4 Sep 2009 13:34:01 -0400 Date: Fri, 4 Sep 2009 07:33:17 -1000 (HST) From: Linus Torvalds To: Alan Cox cc: OGAWA Hirofumi , "Rafael J. Wysocki" , Mikael Pettersson , Linux Kernel Mailing List , Kernel Testers List , Alan Cox , Greg KH , Andrew Morton Subject: Re: [Bug #14015] pty regressed again, breaking expect and gcc's testsuite In-Reply-To: <20090904162807.1dba7a32@lxorguk.ukuu.org.uk> Message-ID: References: <19099.52899.620345.326521@pilspetsen.it.uu.se> <19100.31254.666066.755541@pilspetsen.it.uu.se> <200909012042.59856.rjw@sisk.pl> <87pra89sgp.fsf@devron.myhome.or.jp> <20090904162807.1dba7a32@lxorguk.ukuu.org.uk> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 23 On Fri, 4 Sep 2009, Alan Cox wrote: > > In which case ppp will no longer work properly in some cases (ditto > other protocols) and things like the pppoe gateway wont work as they > don't in 2.6.30 - you need to go back to somewhere between 2.6.28/29 to > undo this, then apply the alternative locking patches to the > ppp/slip/ax25/etc ldiscs It should be fairly trivial to just add the locking to the pty write routines. That said, we need to fix the 2.6.31 regression, and right now that is the big one. If we go back to broken 2.6.30 situation, that's way more acceptable. But I'm still hoping we can fix this. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/