Date: Fri, 4 Sep 2009 14:03:25 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: jgunthorpe@obsidianresearch.com, tpmdd-devel@lists.sourceforge.net,
       linux-kernel@vger.kernel.org, srajiv@linux.vnet.ibm.com,
       debora@linux.vnet.ibm.com, m.selhorst@sirrix.com, jmorris@namei.org,
       jbeulich@novell.com
Subject: Re: [PATCH] TPM: Fixup pubek sysfs file
Message-Id: <20090904140325.c592289a.akpm@linux-foundation.org>
In-Reply-To: <adaab1bnvz3.fsf@cisco.com>
References: <20090904045231.GW4973@obsidianresearch.com>
	<adaab1bnvz3.fsf@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 860
Lines: 24

On Thu, 03 Sep 2009 22:02:24 -0700
Roland Dreier <rdreier@cisco.com> wrote:

> 
>  > Algorithm: 00 00 00 01
>  > Encscheme: 00 03
>  > Sigscheme: 00 01
>  > Parameters: 00 00 08 00 00 00 00 02 00 00 00 00
>  > Modulus length: 256
> 
> No argument that this fix is an improvement, but what happened to the
> "one value per file" rule for sysfs??

We goofed.  This one snuck through.

It's one of the reasons why I recommend that people cite examples of
the sysfs/procfs output in changelogs.  These things are part of the
kernel ABI and once they go in we cannot change them so we have to get
them right first time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/