Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934703AbZIEAXm (ORCPT ); Fri, 4 Sep 2009 20:23:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934683AbZIEAX3 (ORCPT ); Fri, 4 Sep 2009 20:23:29 -0400 Received: from kroah.org ([198.145.64.141]:42297 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964819AbZIEAVc (ORCPT ); Fri, 4 Sep 2009 20:21:32 -0400 X-Mailbox-Line: From gregkh@mini.kroah.org Fri Sep 4 17:14:57 2009 Message-Id: <20090905001457.367326335@mini.kroah.org> User-Agent: quilt/0.48-1 Date: Fri, 04 Sep 2009 17:14:40 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Eric Dumazet , Oliver Hartkopp , "David S. Miller" Subject: [patch 65/71] can: Fix raw_getname() leak References: <20090905001335.106974681@mini.kroah.org> Content-Disposition: inline; filename=can-fix-raw_getname-leak.patch In-Reply-To: <20090905001824.GA18171@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 29 2.6.30-stable review patch. If anyone has any objections, please let us know. ------------------ From: Eric Dumazet commit e84b90ae5eb3c112d1f208964df1d8156a538289 upstream. raw_getname() can leak 10 bytes of kernel memory to user (two bytes hole between can_family and can_ifindex, 8 bytes at the end of sockaddr_can structure) Signed-off-by: Eric Dumazet Acked-by: Oliver Hartkopp Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/can/raw.c | 1 + 1 file changed, 1 insertion(+) --- a/net/can/raw.c +++ b/net/can/raw.c @@ -397,6 +397,7 @@ static int raw_getname(struct socket *so if (peer) return -EOPNOTSUPP; + memset(addr, 0, sizeof(*addr)); addr->can_family = AF_CAN; addr->can_ifindex = ro->ifindex; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/