Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757329AbZIEKql (ORCPT ); Sat, 5 Sep 2009 06:46:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757288AbZIEKqk (ORCPT ); Sat, 5 Sep 2009 06:46:40 -0400 Received: from fanny.its.uu.se ([130.238.4.241]:48094 "EHLO fanny.its.uu.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757217AbZIEKqj (ORCPT ); Sat, 5 Sep 2009 06:46:39 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19106.16773.461397.654704@pilspetsen.it.uu.se> Date: Sat, 5 Sep 2009 12:46:29 +0200 From: Mikael Pettersson To: Linus Torvalds Cc: Mikael Pettersson , "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Alan Cox , Greg KH , Andrew Morton , OGAWA Hirofumi Subject: Re: [Bug #14015] pty regressed again, breaking expect and gcc's testsuite In-Reply-To: References: <19099.52899.620345.326521@pilspetsen.it.uu.se> <19100.31254.666066.755541@pilspetsen.it.uu.se> <200909012042.59856.rjw@sisk.pl> <19105.5352.28380.230615@pilspetsen.it.uu.se> X-Mailer: VM 7.17 under Emacs 20.7.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 987 Lines: 25 Linus Torvalds writes: > > > On Fri, 4 Sep 2009, Linus Torvalds wrote: > > > > I'm sure you already figured the obvious meaning out, but here's a fixed > > version. > > And here's another patch that may also fix this, simply by virtue of > writing the "\r\n" as a single string, rather than as two characters. That > way, we should never get into the situation that th '\r' allocates a new > buffer (larger than one character), and then the later '\n' writing > decides that we've filled up. Thanks, I'm testing this and the pty_write() fix on i686 and ppc64 now. Sometimes the bug is difficult to trigger, so I may need to do loads of testing with different gcc versions before I dare to say that it's fixed. /Mikael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/